From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933191AbdBHMzY (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Feb 2017 07:55:24 -0500
Received: from mail.skyhub.de ([78.46.96.112]:52269 "EHLO mail.skyhub.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S932289AbdBHMyc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Feb 2017 07:54:32 -0500
Date: Wed, 8 Feb 2017 13:54:24 +0100
From: Borislav Petkov <bp@alien8.de>
To: Lee Jones <lee.jones@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: rtsx: Convert forgotten dev_info() statement to
 pcr_dbg()
Message-ID: <20170208125424.jun6unesnxk45sd6@pd.tnic>
References: <20170202205935.1452-1-bp@alien8.de>
 <20170208120222.pyhxy2c4yfzy32sj@dell>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20170208120222.pyhxy2c4yfzy32sj@dell>
User-Agent: NeoMutt/20161014 (1.7.1)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 08, 2017 at 12:02:22PM +0000, Lee Jones wrote:
> I usually disapprove of these kinds of abstractions.
> 
> What is the point of it?
> 
> Why can't you just use dev_dbg()?

I was simply following what the rest of the driver does. It has 20
pcr_dbg() calls and 5 dev_dbg().

If you want to address that, then a patch ontop should convert all
pcr_dbg() calls to dev_dbg().

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.