From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754540AbdBHPi1 (ORCPT ); Wed, 8 Feb 2017 10:38:27 -0500 Received: from mail-by2nam03on0050.outbound.protection.outlook.com ([104.47.42.50]:19488 "EHLO NAM03-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752869AbdBHPiN (ORCPT ); Wed, 8 Feb 2017 10:38:13 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Robert.Richter@cavium.com; Date: Wed, 8 Feb 2017 16:36:58 +0100 From: Robert Richter To: Shanker Donthineni CC: Marc Zyngier , Thomas Gleixner , Jason Cooper , , Subject: Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation Message-ID: <20170208153658.GT5020@rric.localdomain> References: <20170201173833.12630-1-rrichter@cavium.com> <20170201173833.12630-2-rrichter@cavium.com> <87tw847njl.fsf@on-the-bus.cambridge.arm.com> <20170208144328.GS5020@rric.localdomain> <278df776-4d6d-3b89-7a94-effaafcebeb0@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <278df776-4d6d-3b89-7a94-effaafcebeb0@codeaurora.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-Originating-IP: [92.229.81.133] X-ClientProxiedBy: VI1PR0901CA0076.eurprd09.prod.outlook.com (10.167.203.172) To BL2PR07MB2340.namprd07.prod.outlook.com (10.167.101.18) X-MS-Office365-Filtering-Correlation-Id: aacfa267-1c28-4c6c-d393-08d4503858f8 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:BL2PR07MB2340; X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2340;3:7cSp7N5mgW+lKcLPOOCdT6Kv09beOpSvH70O3o+1vSsLJwfYXOmn3ORtD5VD6FmAsi63QLOTxn+65Mr6TXtAKvzia/ev6C+iuuiCCv3te+soeJGr4A+s6zv0BvUOjvtLLwkzJqsTtizwhabHxq0G1zQGF3eDSWnPssnS3nBMo+7A978VeNwrZvpaYXk66ztQ0QWyeR+4ieyk0P48czcUg9LPvwkSFySLTu9zYWZhDdj3ehIYH9DuDq8Cmvm+GyWE66C0LL7gOPr0QBHzFOe0oQ==;25:nITM0obuiYnmLUC0+/wy8JqqNfTzq/+vonN5+TIwQQKoJLJkkIdyWxfPNFw3LW9jLxn/GX0tFswCe5d71EV1SYcrwdqoJK3QQRtNifsUKn96EaW63HaRrs3alw+muDfJW5gekuOnJroenFMO/uh3gGUvcD0+StD9VvxEiCfR+OHycFpOvoG8+hhotvH/nHyS9dxRKsgurrJQI2UwhD6XALWmVG7C9QYwCd8x1v6lSYNKc9HAEGZnrLdet/+Mg20ydaQMSIGSRf99MrHO50eRmeE46h+qynZFV8mI/y0fhAkQFOuig1OeiV8UBPL1FEWOuRcsXuKbboTBWthrJqInC5BPjrkcIsEPaKk6KyAIy7ZXYhQbqr6B001goarr8o1CmvRlvCYjK+YehoqcTRo/a7WW6UhbvYUJQbirrJh49SNqmS8qB1++SEbkk8RHQi3DPc3aOOpEY+/xagtCk1RF5w== X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2340;31:s6Ds10wDGHPpx1QZLoL4FKpp/QGUK16+cmbNdNtBXDb81ncWM4FpqaLpWXQkRn1AxbOM150M2MqTJdeSv2xxNLwNxMHnXDkLgdc8rRijW3gYZjo5KIcKQg+78n/Wd7/FKXDyozJ/IKNYd8aNoWKlRyqqhzAWN5CO/Cy0XFaoBuq2A8ZzbB7fSqKnGUat88oSrBTCzA1Jsv29SEsK6VUg4OGCXxHtbEDLSEZUlyL++NFWDc8ZpbokcATkjefKLfbkCryTidY9D1bTECqp5ARqRWUxfcsG6XHMz5onNjwaGjQ=;20:nhd+uy8DiOd1ArLssH7aeYPbgUCfFiGXVEY7dj9V65rfRiKcf57XHoGu55S8OIwhHrHyv+xgP/l+a/RQ03NYa/JKftH72G9zzHx+wh/TDrCRxSBZ5X3BHANSY0pPb+DzmAP1Fl0aRiXjRVzL46JWeeQT0Pr96PDi+jecSezB5FDQ7PiA/DueGfi477v2Ifwwmm9MwNzlW5XQUqroLvf+1hI3H8GNk03hn5miNL2aTKu9Om5wNnnWuYPBElsHZCWQjmefdMq2QMuli66TCOhxt24crkXdtbHkUSyu1u1LEkxFxqkKj6XX3/ynQBJbsYlJM7yZtWs/5+2XTQ3o5CR8IMPcYDgRTP0QnWHxYBOTsBpkXZoFxKa/TPmDIQxtdoWS9txcTWe6xqUL5+zatXm1kx5Cy2zzfYu9iqnQ9ZIl5twbYrvdOXd1/LnS4aNTFcJ0MUyGpZCW/fb9m2IcwlzhjWKCba9BQYkOp/3Dx1zHHvAVVS1HjY+kItGJm0vBcz3G X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(20170203043)(2017020702029)(5005006)(8121501046)(3002001)(10201501046)(6041248)(20161123564025)(20161123562025)(20161123558025)(20161123555025)(20161123560025)(6072148);SRVR:BL2PR07MB2340;BCL:0;PCL:0;RULEID:;SRVR:BL2PR07MB2340; X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2340;4:GoE/cJjuSt+TeY5D7wYN3a00vZwYarJ++hv5T341+dVbZ7nCNVMLuQLm612GjV6ebZynQVzTa6pmYiwOOkzHk6D41Ua2yvbvOSfoiYiNNs6MIQBmerjsEJchicFItmf6nrViELsiq5YqQsYzmztKHiAbRkyhIhjbvBYDh+CD5AaH0G4Qm2QRW8Z+UXxrjGRDY2dxTgN/uUs8DhKhxsUsdVTWeIis3RJ31FGe2W6FY5OAfW+E3U01MyS0DuxojTmcYZmPfu2Oz7lQtaJLEhb+J0mCkQMBmHJQU/378wg3uCU05XGkwqWETi50VP+r/+R7Z9Yv/+CZB5dvsRBVYVAySWqxZNk/A0K8onItpsgZXyPDpsGRJmxegMUsf0sbjlce5lKInPjwl9esRg6RN7Tn0g5b0V6y5zEKfd2AWG+QM1aaMr5cnmK3HG81JGynr+tZcouzBLDT7vpNkRwPaehH2b+DMKzeysSLoTA1S8yhH5AYzFQ1wXXHF1Jiv1+WrPsCJQf70tc8z2DF0ZIPuij/W5XccSEz8rzbbNH4y785H2dSPAmNOlAAkfWD2SgZ+PjJkCrCwjfOvpo3i/I+uxyUqTVcQMGzT1rjEaB3IRWo97Ec3/72csuF6cK45zvzb+V5NFELDfg5Mab836aEiGxWDK8KUT4VeXVLdCadbMZ1BZM= X-Forefront-PRVS: 0212BDE3BE X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39450400003)(189002)(199003)(24454002)(46406003)(25786008)(6506006)(66066001)(105586002)(38730400002)(230783001)(33656002)(110136004)(50466002)(93886004)(106356001)(42186005)(2906002)(83506001)(53936002)(86362001)(229853002)(2950100002)(6666003)(1076002)(3846002)(23726003)(68736007)(6916009)(6116002)(55016002)(97756001)(54906002)(305945005)(9686003)(4326007)(4001350100001)(189998001)(92566002)(97736004)(81166006)(5660300001)(8676002)(81156014)(47776003)(53546003)(6246003)(54356999)(50986999)(101416001)(76176999)(7736002)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:BL2PR07MB2340;H:rric.localdomain;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BL2PR07MB2340;23:pC7a7BTxjlzUa/kJugM+pIeNyz1IgRJFyGAYvqhP3?= =?us-ascii?Q?5tn+IjgNDqbgGYyavgb6y/Cw7Z9+xwZxVEiBH7HAMveg4UyN5zFyaFn+Hf1l?= =?us-ascii?Q?foJZ2FexdfkBUY570tvkY8IUHu/QsvDMn9bLxlI84YJfQvaR70pCR7VVvdPz?= =?us-ascii?Q?nWS94IkYonT9/dazk8CURvw7yIAQHKNu7LUAhmpIkCFSkVV1XQQdaobEVeoj?= =?us-ascii?Q?wZ3ZEjlHcm/PJdisXmhF1kSlvculj5hkF7V0fcG9yPfIoolr10yM+OkQt8WS?= =?us-ascii?Q?DaGH6w1p3IhMqftxnmwsj4LZOcJuIdxppbDUm2u81xnsxUGQhCIUT7yoesst?= =?us-ascii?Q?p04RDUe5YTiKcoX6DX69MPsiHY8xCJsJS2/4jzkO4Ll3TwlO0FgwLlkytk6M?= =?us-ascii?Q?KeUAuAQJ8/BerWlNNUfllPG7h9pNpNhqED8d+sMgZ8pbL5FdlmoX2B9+HjtJ?= =?us-ascii?Q?85qd7PFXVq+xEzXCLdY5C7VvoBrJ/6rGK/albbAjLBTD4v8v81M79Eqcave+?= =?us-ascii?Q?a3mK9RzWsFDhER1Zr5i7lnj3H3CS1BTWuYT63CRi3AD1DONXcIP+dkvT+DPZ?= =?us-ascii?Q?0LSyPjHFtELsiiIrMNQzel8ngTjwZuWWjaKoSsKwC5bbyDDjPpF1hNaG/B9X?= =?us-ascii?Q?AQvsTQH0wVeuhMrUEbG9oROeTEskIt7X51dhqsfqMBZZhGd6ZC1EVhzYGAz7?= =?us-ascii?Q?anAMzBy4+x4wCqwCGpE52XVfwfjCPMxVAUeYPC+T09meJG1YS2FRM22lobBf?= =?us-ascii?Q?TA3icktJ0pm/SghH30+CgR415ISaRkZ4Nw4fewRhn4ElEhBjo3F+mmxL9E7o?= =?us-ascii?Q?pcp8kD35jTvL4E5TzjrsP8638chwvY4dojHl2s4a3VrLCxsjQ34HVbIUHrs+?= =?us-ascii?Q?Lwo6vYG0A+4/rOy1DuV9XKdTn2+K2IwM44UKZV+brgLyoXGsuR9y2Dw4OX7x?= =?us-ascii?Q?Wb0eA6YZChDcCY7BDksnso6lMs8ATSHUgl2YbFKVziJqxGKixA7qyJLveWMi?= =?us-ascii?Q?9N8tBUAHv6HWzFnMvVUxLZuGQX+5U8df0ff150D8Uwmt2+Xtwt8EXS8Nlmi8?= =?us-ascii?Q?PyndLuTuNFJtQLibSeBlWC3rHtQFk1je4ESOoQVWSqp+SsR3qf6sEHQXEDh/?= =?us-ascii?Q?k7wTPBmLFLo4bKbhpzp2UeZwFmt6cbP6QkjnSp96BoCJAi0L5ZI3ECTWZQft?= =?us-ascii?Q?MzhI0Mi0i3dpP/K+zxuha9SBCSfAt92huHsU2pija2hrNnXmusjERxtMLYpi?= =?us-ascii?Q?/zCGLrodXBw35lsab7P5a87VeNu2exWiCSRHqwGxUv5xJgJ8bNsSj1SLgwOM?= =?us-ascii?Q?Lbwrke3cN3z3K4nEWOuKf6fOShvwMFES2qqwiz/8l/T?= X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2340;6:bFIkLMKf3ZWtfjdd/j5dvTWGJuaotkzYqUrd7SV4kc4qfgdMaD/mIV8L1+5/tRd6TOm414ju8kQf/GaxIqGfDQ5CoyGJKhAPfDeLDK4TGPs8GFOb5jSRcewXuN5qh+3Xt7NJNoQZNlJsnLUSbpCOxRXjDxglYPTU9sDYcdshKU/KOZPdLIUMzdYrX2+dGqfuyKTsM16A6+ZkKHRh5zBebekNy08gnSfJNFDpONf9dvkXWQxW3eWPlGHylJSd0+iX9M7LlLp5XQOLcwQwbQVp0bbtV3T90ywKgzw/UkFv9yyhuT+tC8OCgSoYnDWkuHMEnyd4fNdgoaTktpGAZBKts8stlQSfJPVxC9kQm674yrtuqCXWssEg8SyH+JiVadR2ppqMfBCaF9NHSxqCj6s3NQ==;5:hTBC9I5oeyKx9HCwtnkGtRUbPCGbU9pfJ9o4a99AYx/sZ12cZLBi4aAVSJdo8EMgGUP3ClvDUDnq73t2QmC2a76X41wf/LvT4px6C+LYfg2NyGT/QCD83RjVnttgWLIDSPWXiruZ5JFEHTgHGYNSEw==;24:/oNT0EPTH+XL31Trgmlct4Gcn1bpNzcRQwgDRDZy2b9bezLLJiurTtjx/AsJ2ZJjLAhkltAKXYP0o5/9TVYq2TqoUonr74GanE9V9cH4ONo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;BL2PR07MB2340;7:5BskFMw0coEj7Sf+dpdt74h6aYu/duFcCBnkGUKjaSF6U6VyKzUnmFfJJ0XwWJFWaDnsdz6t5rTRGvthwPXus7fj65Fw/rUIHurySvidv8m31FGUAF+KC0jirCWtZF/maJI/1Az7KsJ72nUZPOicGnIkD03IodhKhNJtjMKv+mCRpv6s1jAnX8l4p9tgtjN/muopyEZbwuhA403W08CQ9s6gEqsEYlq2147QqqqQEd5bqBa8OHeG9zbH5bxs8gN0MMcwRpGoRm68EOw+kD8/lNaqaxnPjXmHCW8mvvJtQmWM5cejDO8iAsW2sodIx3jbpJzQB4iMszsSZZeJF3Hj9E8vdaRvDzTBATTCZnKWf0yIbgUC5qVJFh/trdCnXa5AZcJeaQS/LeuvilHjFRlh99FconST3AjR19+bu8dsAY1ENpZ/PNrvI2U4qb3vSeZZ3LRNBNOZBj/yjQbsBTB8CpP/UajAXWOBDYc4jnrfeG7XOk9dY88gAekTMxYaMiwSvJ/h47HlBBJEQH7KGMnVTA== X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Feb 2017 15:37:09.5085 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL2PR07MB2340 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08.02.17 09:31:00, Shanker Donthineni wrote: > In teardown path, code is still calling 'kfree(its->cmd_base)' to free > memory, this should be changed to 'free_pages(get_order(ITS_CMD_QUEUE_SZ). Hmm, right. This is later removed in the series, but should be part of this patch. Should I respin this one? -Robert