From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752996AbdBHQIi (ORCPT ); Wed, 8 Feb 2017 11:08:38 -0500 Received: from mga01.intel.com ([192.55.52.88]:5573 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751859AbdBHQIe (ORCPT ); Wed, 8 Feb 2017 11:08:34 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,348,1477983600"; d="scan'208";a="931567551" From: Andy Shevchenko To: linux-kernel@vger.kernel.org, platform-driver-x86@vger.kernel.org Cc: Andy Shevchenko , Shanth Murthy , Rajneesh Bhardwaj , Zha Qipeng , Darren Hart , Andy Shevchenko Subject: [PATCH v1] platform/x86: intel_pmc_ipc: fix division in 32-bit case Date: Wed, 8 Feb 2017 18:00:28 +0200 Message-Id: <20170208160028.13308-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.11.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 32-bit x86 platforms we can't do 64-bit divisions: ERROR: "__udivdi3" [drivers/platform/x86/intel_pmc_ipc.ko] undefined! Replace plain division by do_div() macro call. Reported-by: Darren Hart Cc: Shanth Murthy Cc: Rajneesh Bhardwaj Signed-off-by: Andy Shevchenko --- drivers/platform/x86/intel_pmc_ipc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel_pmc_ipc.c b/drivers/platform/x86/intel_pmc_ipc.c index 46202b6e7c87..8ad4d7b43423 100644 --- a/drivers/platform/x86/intel_pmc_ipc.c +++ b/drivers/platform/x86/intel_pmc_ipc.c @@ -62,7 +62,12 @@ #define GCR_TELEM_SHLW_S0IX_OFFSET 0x1080 /* Residency with clock rate at 19.2MHz to usecs */ -#define S0IX_RESIDENCY_IN_USECS(d, s) (((d) + (s)) * 10 / 192) +#define S0IX_RESIDENCY_IN_USECS(d, s) \ +({ \ + u64 result = 10ull * ((d) + (s)); \ + do_div(result, 192); \ + result; \ +}) /* * 16-byte buffer for sending data associated with IPC command. -- 2.11.0