From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754162AbdBIV5U (ORCPT ); Thu, 9 Feb 2017 16:57:20 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51188 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752926AbdBIV5Q (ORCPT ); Thu, 9 Feb 2017 16:57:16 -0500 Date: Thu, 09 Feb 2017 16:46:55 -0500 (EST) Message-Id: <20170209.164655.35358163111689337.davem@davemloft.net> To: ross.lagerwall@citrix.com Cc: xen-devel@lists.xenproject.org, netdev@vger.kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com, linux-kernel@vger.kernel.org, wei.liu2@citrix.com Subject: Re: [PATCH v3] xen-netfront: Improve error handling during initialization From: David Miller In-Reply-To: <1486551457-25963-1-git-send-email-ross.lagerwall@citrix.com> References: <1486551457-25963-1-git-send-email-ross.lagerwall@citrix.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 09 Feb 2017 12:47:58 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ross Lagerwall Date: Wed, 8 Feb 2017 10:57:37 +0000 > This fixes a crash when running out of grant refs when creating many > queues across many netdevs. > > * If creating queues fails (i.e. there are no grant refs available), > call xenbus_dev_fatal() to ensure that the xenbus device is set to the > closed state. > * If no queues are created, don't call xennet_disconnect_backend as > netdev->real_num_tx_queues will not have been set correctly. > * If setup_netfront() fails, ensure that all the queues created are > cleaned up, not just those that have been set up. > * If any queues were set up and an error occurs, call > xennet_destroy_queues() to clean up the napi context. > * If any fatal error occurs, unregister and destroy the netdev to avoid > leaving around a half setup network device. > > Signed-off-by: Ross Lagerwall Applied.