From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932462AbdBIWLX (ORCPT ); Thu, 9 Feb 2017 17:11:23 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:51562 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754038AbdBIWLS (ORCPT ); Thu, 9 Feb 2017 17:11:18 -0500 Date: Thu, 09 Feb 2017 17:04:22 -0500 (EST) Message-Id: <20170209.170422.2219490608301068441.davem@davemloft.net> To: jon.mason@broadcom.com Cc: rafal@milecki.pl, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, zschroff@broadcom.com Subject: Re: [PATCH net v3 1/2] net: ethernet: bgmac: init sequence bug From: David Miller In-Reply-To: <1486588377-7681-2-git-send-email-jon.mason@broadcom.com> References: <1486588377-7681-1-git-send-email-jon.mason@broadcom.com> <1486588377-7681-2-git-send-email-jon.mason@broadcom.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 09 Feb 2017 13:05:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jon Mason Date: Wed, 8 Feb 2017 16:12:56 -0500 > The code now checks to see if the adapter needs to be brought out of > reset (where as before it was doing an IDM write to bring it out of > reset regardless of whether it was in reset or not). Also, removed > unnecessary usleeps (as there is already a read present to flush the > IDM writes). That's not what the delays are there for, I don't think you can safely remove them. It's for waiting for the reset to complete after the write to the register has propagated by the read back. Please retain the delays. Thanks.