From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751954AbdBIIhu (ORCPT ); Thu, 9 Feb 2017 03:37:50 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:45222 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751674AbdBIIht (ORCPT ); Thu, 9 Feb 2017 03:37:49 -0500 Date: Wed, 8 Feb 2017 23:18:19 -0800 From: Christoph Hellwig To: Scott Bauer Cc: linux-nvme@lists.infradead.org, axboe@fb.com, keith.busch@intel.com, jonathan.derrick@intel.com, hch@infradead.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org Subject: Re: [PATCH v2] Move stack parameters for sed_ioctl to prevent oversized stack with CONFIG_KASAN Message-ID: <20170209071819.GA20996@infradead.org> References: <1486594815-2427-1-git-send-email-scott.bauer@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486594815-2427-1-git-send-email-scott.bauer@intel.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I'm really not a fan of adding a global synchronization point for no good reason. Arnd's original patch looks fine to me, but if you really don't want it I'd suggest to use memdup_user and just dynamically allocate the structure.