From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752084AbdBIIxw (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Feb 2017 03:53:52 -0500
Received: from merlin.infradead.org ([205.233.59.134]:57096 "EHLO
        merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752009AbdBIIxt (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Feb 2017 03:53:49 -0500
Date: Thu, 9 Feb 2017 09:53:46 +0100
From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@kernel.org>
Cc: linux-kernel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Mike Galbraith <efault@gmx.de>, Oleg Nesterov <oleg@redhat.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH 05/10] sched/core: Remove the tsk_cpus_allowed() wrapper
Message-ID: <20170209085346.GZ6500@twins.programming.kicks-ass.net>
References: <1486578863-8903-1-git-send-email-mingo@kernel.org>
 <1486578863-8903-6-git-send-email-mingo@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1486578863-8903-6-git-send-email-mingo@kernel.org>
User-Agent: Mutt/1.5.23.1 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 08, 2017 at 07:34:18PM +0100, Ingo Molnar wrote:
> So the original intention of tsk_cpus_allowed() was to 'future-proof'
> the field - but it's pretty ineffectual at that, because half of
> the code uses ->cpus_allowed directly ...
> 
> Also, the wrapper makes the code longer than the original expression!

I still object to taking this out without replacement. This leaves RT
stranded.

If you want to implement it differently do that, but don't blindly wreck
stuff for them.