From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753525AbdBIPSR (ORCPT ); Thu, 9 Feb 2017 10:18:17 -0500 Received: from mout.kundenserver.de ([212.227.126.130]:57722 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752628AbdBIPQp (ORCPT ); Thu, 9 Feb 2017 10:16:45 -0500 From: Arnd Bergmann To: Philipp Zabel , Mauro Carvalho Chehab Cc: Arnd Bergmann , Michael Tretter , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [media] coda/imx-vdoa: platform_driver should not be const Date: Thu, 9 Feb 2017 16:09:08 +0100 Message-Id: <20170209150940.1167088-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:eCE5b7oRUXiTJOimtzy9FBJsYa8jCAlNHrrddFbpyNN3GzX1n+Q IYvTZ0i5/3bt96vx8NcDRxaZ/dU7HzwI/u6hv+aLG6ZpzirdeXn2sml0a5/ZUkCkdfVAAn2 efXCguibkFUd1su/zaASMSms/VdIAE9YwDG75HBSrTZlJwD87SpH3hW0HXyALF5iFmjQOE5 RWqIxm4ZKfuXRixJkuhkQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:/OVVIHsDMuY=:RDtSw5Li4r26wXORdd06v3 UbQhsjXuBOiISA82jtVg6o5Bz635T7WB7sJ0Je9Lh4Xg12WEaIOuLvXS6pNxUjLK2RPpbw3rb /lXUtZZ69m7C65G30r91lsAsphiqqjQR7EUak1bleBKfklAhVKkj3fuLWSct0CGF+wELE7NPI 7Sdcx7YZSOxtBoikTSLH7VJuj/GEulpNWCJrWbjlMRiG/lGxkjxN2fKh5OSISrViQzr8Z9drj 1UOu7S2hwxV/XHMmN8HNeWPb+kltAGlFBu/sb7jUrBmAT4Tv66lFsm8/N6Er1fXo+7miN/aAW AT/2IhbqO1iv+8k4JMNU/SMtDbXIvieJw1HHdkkd8DvjM9DtabrzNGSopjLPH7DU8j+zl+6sd WXJjSZDXcQqNKoA7rGCNMqPX5xBozjBUkjaumIyWcWa1f8/hBsSC2osWj0BnnRZ8oSxCwmEo5 yQ7QA66vtHPZmvTiarFsDIziNs9esM328eeO0kpnlXBx/7alNkOF+BtCVrIlqyAmHK01pqplS um9P6FOR+MDlUYvOB4qwqM1GytItcXecqC8UGuVt8siSsGoLKnmb9fSZCVtQCqpWXkqoiZebF b8iGNg5W6xi+dlD/ZO5rCRbrLFpFTe+3CNFZgF5HXO/Xml/gVXqJiydzqYinrrX1SKEYxwMse 80/0H9Ldzr6vC1VhbLBhUxFdrrkDT3J4xVPUICfhmg6z63SAR+YpJFA+tHMz8DHMhT6E= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The device driver platform is actually written to during registration, for setting the owner field, so platform_driver_register() does not take a const pointer: drivers/media/platform/coda/imx-vdoa.c: In function 'vdoa_driver_init': drivers/media/platform/coda/imx-vdoa.c:333:213: error: passing argument 1 of '__platform_driver_register' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] module_platform_driver(vdoa_driver); In file included from drivers/media/platform/coda/imx-vdoa.c:22:0: include/linux/platform_device.h:199:12: note: expected 'struct platform_driver *' but argument is of type 'const struct platform_driver *' extern int __platform_driver_register(struct platform_driver *, ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/media/platform/coda/imx-vdoa.c: In function 'vdoa_driver_exit': drivers/media/platform/coda/imx-vdoa.c:333:626: error: passing argument 1 of 'platform_driver_unregister' discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] Remove the modifier again. Fixes: d2fe28feaebb ("[media] coda/imx-vdoa: constify structs") Signed-off-by: Arnd Bergmann --- drivers/media/platform/coda/imx-vdoa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/platform/coda/imx-vdoa.c b/drivers/media/platform/coda/imx-vdoa.c index 67fd8ffa60a4..669a4c82f1ff 100644 --- a/drivers/media/platform/coda/imx-vdoa.c +++ b/drivers/media/platform/coda/imx-vdoa.c @@ -321,7 +321,7 @@ static const struct of_device_id vdoa_dt_ids[] = { }; MODULE_DEVICE_TABLE(of, vdoa_dt_ids); -static const struct platform_driver vdoa_driver = { +static struct platform_driver vdoa_driver = { .probe = vdoa_probe, .remove = vdoa_remove, .driver = { -- 2.9.0