From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753684AbdBIP3W (ORCPT ); Thu, 9 Feb 2017 10:29:22 -0500 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34978 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753662AbdBIP3T (ORCPT ); Thu, 9 Feb 2017 10:29:19 -0500 From: Wei Yongjun To: Sekhar Nori , Bartosz Golaszewski , Rob Herring , Kevin Hilman Cc: Wei Yongjun , linux-kernel@vger.kernel.org Subject: [PATCH -next] memory: da8xx-ddrctl: remove redundant dev_err call in da8xx_ddrctl_probe() Date: Thu, 9 Feb 2017 15:28:57 +0000 Message-Id: <20170209152857.1213-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun --- drivers/memory/da8xx-ddrctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/memory/da8xx-ddrctl.c b/drivers/memory/da8xx-ddrctl.c index 030afbe..3286aee 100644 --- a/drivers/memory/da8xx-ddrctl.c +++ b/drivers/memory/da8xx-ddrctl.c @@ -122,10 +122,8 @@ static int da8xx_ddrctl_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); ddrctl = devm_ioremap_resource(dev, res); - if (IS_ERR(ddrctl)) { - dev_err(dev, "unable to map memory controller registers\n"); + if (IS_ERR(ddrctl)) return PTR_ERR(ddrctl); - } for (; setting->name; setting++) { knob = da8xx_ddrctl_match_knob(setting);