From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753648AbdBIPbk (ORCPT ); Thu, 9 Feb 2017 10:31:40 -0500 Received: from pandora.armlinux.org.uk ([78.32.30.218]:38932 "EHLO pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752162AbdBIPbi (ORCPT ); Thu, 9 Feb 2017 10:31:38 -0500 Date: Thu, 9 Feb 2017 15:31:01 +0000 From: Russell King - ARM Linux To: Stephen Boyd Cc: Rob Herring , Frank Rowand , devicetree@vger.kernel.org, Linus Walleij , Pantelis Antoniou , linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Mark Brown , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v3 1/3] of: Support parsing phandle argument lists through a nexus node Message-ID: <20170209153101.GE27312@n2100.armlinux.org.uk> References: <20170123204851.12808-1-stephen.boyd@linaro.org> <20170123204851.12808-2-stephen.boyd@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170123204851.12808-2-stephen.boyd@linaro.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 23, 2017 at 12:48:49PM -0800, Stephen Boyd wrote: > connector: connector { > #gpio-cells = <2>; > gpio-map = <0 0 &soc_gpio1 1 0>, > <1 0 &soc_gpio2 4 0>, > <2 0 &soc_gpio1 3 0>, > <3 0 &soc_gpio2 2 0>; > gpio-map-mask = <0xf 0x0>; > gpio-map-pass-thru = <0x0 0x1> This -map-mask and -map-pass-thru mechanism needs documentation in Documentation/devicetree. There's a bunch of users of -map-mask (eg, interrupt-map-mask) but there's nothing that actually describes how this works. The "-map-pass-thru" thing also seems to be a new, undocumented idea. So, NAK until this stuff goes through the same level of review WRT DT documentation as other bindings are required to. I'm not saying that it's a bad idea, but it's important for consistency that this stuff is well documented, and people don't end up having to interpret the code when writing their DT descriptions. -- RMK's Patch system: http://www.armlinux.org.uk/developer/patches/ FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up according to speedtest.net.