From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Stephen Boyd <stephen.boyd@linaro.org>,
Pantelis Antoniou <pantelis.antoniou@konsulko.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v3 1/3] of: Support parsing phandle argument lists through a nexus node
Date: Thu, 9 Feb 2017 15:35:26 +0000 [thread overview]
Message-ID: <20170209153526.GF27312@n2100.armlinux.org.uk> (raw)
In-Reply-To: <CAL_JsqKbkynNmCrXbi=VJ5wqYtRrYbC+00qSm_uyZFBLFOUz0w@mail.gmail.com>
On Thu, Feb 09, 2017 at 09:17:58AM -0600, Rob Herring wrote:
> Frank, any more comments on this? If not, I plan to apply this series.
Well, I find that a little annoying, because DT has the requirement
that new bindings are properly documented in Documentation, and it
appears that this comes with no documentation what so ever, despite
introducing new properties (like the -map-mask-passthru thing).
So I'm NAKing it until there's some documentation of how this
mechanism is supposed to work.
Merely providing an example in a commit log is (IMHO) insufficient.
An example doesn't explain how it was created, or how to create an
implementation.
Remember, we expect people to do exactly that, so we need to give
them this information so that they can make use of it.
I did try to work out from the code how the -map-mask thing worked,
but eventually gave up.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-02-09 15:36 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 20:48 [PATCH v3 0/3] OF phandle nexus support + GPIO nexus Stephen Boyd
2017-01-23 20:48 ` [PATCH v3 1/3] of: Support parsing phandle argument lists through a nexus node Stephen Boyd
2017-01-24 6:36 ` Frank Rowand
2017-01-24 18:05 ` Rob Herring
2017-02-09 15:17 ` Rob Herring
2017-02-09 15:35 ` Russell King - ARM Linux [this message]
2017-02-09 16:00 ` Rob Herring
2017-02-09 19:55 ` Stephen Boyd
2017-02-09 18:52 ` Frank Rowand
2017-02-09 22:54 ` Frank Rowand
2017-02-09 15:31 ` Russell King - ARM Linux
2017-01-23 20:48 ` [PATCH v3 2/3] of: unittest: Add phandle remapping test Stephen Boyd
2017-01-23 20:48 ` [PATCH v3 3/3] gpio: Support gpio nexus dt bindings Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209153526.GF27312@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pantelis.antoniou@konsulko.com \
--cc=robh+dt@kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®