From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753305AbdBIPtf (ORCPT <rfc822;w@1wt.eu>);
        Thu, 9 Feb 2017 10:49:35 -0500
Received: from pandora.armlinux.org.uk ([78.32.30.218]:39166 "EHLO
        pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752005AbdBIPtd (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 9 Feb 2017 10:49:33 -0500
Date: Thu, 9 Feb 2017 15:49:13 +0000
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Jean-Jacques Hiblot <jjhiblot@traphandler.com>
Cc: Abel Vesa <abelvesa@linux.com>, Steven Rostedt <rostedt@goodmis.org>,
        mingo@redhat.com, viro@zeniv.linux.org.uk,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Petr Mladek <pmladek@suse.com>, robin.murphy@arm.com,
        zhouchengming1@huawei.com
Subject: Re: [PATCHv3] arm: ftrace: Adds support for
 CONFIG_DYNAMIC_FTRACE_WITH_REGS
Message-ID: <20170209154913.GG27312@n2100.armlinux.org.uk>
References: <1486508275-18449-1-git-send-email-abelvesa@linux.com>
 <CACh+v5Nrva=dyJzteomPCzaz01pBBuChesR-9Ft=jeAf0zZoxA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CACh+v5Nrva=dyJzteomPCzaz01pBBuChesR-9Ft=jeAf0zZoxA@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 09, 2017 at 04:38:32PM +0100, Jean-Jacques Hiblot wrote:
> 2017-02-07 23:57 GMT+01:00 Abel Vesa <abelvesa@linux.com>:
> > +#ifdef CONFIG_FUNCTION_GRAPH_TRACER
> > +.macro __ftrace_graph_regs_caller
> > +
> > +       sub     r0, fp, #4              @ lr of instrumented routine (parent)
> > +
> > +       @ called from __ftrace_regs_caller
> > +       ldr     r1, [sp, #56]           @ instrumented routine (func)
> > +       mcount_adjust_addr      r1, r1
> > +
> > +       sub     r2, r0, #4              @ frame pointer
> why not mov r2, fp  ?

	r0 = fp - 4
	r2 = r0 - 4

therefore

	r2 = (fp - 4) - 4
	r2 = fp - 8, not r2 = fp

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.