From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754274AbdBIRZI (ORCPT ); Thu, 9 Feb 2017 12:25:08 -0500 Received: from mail-wr0-f179.google.com ([209.85.128.179]:35747 "EHLO mail-wr0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752834AbdBIRZC (ORCPT ); Thu, 9 Feb 2017 12:25:02 -0500 Date: Thu, 9 Feb 2017 17:57:04 +0100 From: Daniel Vetter To: Mihail Atanassov Cc: dri-devel@lists.freedesktop.org, Liviu Dudau , linux-kernel@vger.kernel.org, Daniel Vetter , nd@arm.com Subject: Re: [RFC] drm: Helper macro for drm state duplication Message-ID: <20170209165704.hh5cb3ywwfg3b2mq@phenom.ffwll.local> Mail-Followup-To: Mihail Atanassov , dri-devel@lists.freedesktop.org, Liviu Dudau , linux-kernel@vger.kernel.org, Daniel Vetter , nd@arm.com References: <1486654902-2558-1-git-send-email-mihail.atanassov@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486654902-2558-1-git-send-email-mihail.atanassov@arm.com> X-Operating-System: Linux phenom 4.8.0-1-amd64 User-Agent: NeoMutt/20161126 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 09, 2017 at 03:41:41PM +0000, Mihail Atanassov wrote: > Hi, > > I was working on a few patches adding fields to struct malidp_crtc_state and > found myself writing memcpy multiple times in the ->atomic_duplicate_state > hook because I wanted to avoid copying the drm_crtc_state twice > (__drm_atomic_helper_crtc_duplicate_state copies it already). I figured this > also applies to the other drm_*_state derivatives, so I concocted a macro > helper to do the copy in one chunk (two if you count the __drm_atomic_helper* > one). I'd appreciate some comments on whether anyone else might find this > macro useful. Thanks! > > Mihail Atanassov (1): > drm: Add helper macro for duplicating custom drm_*_state I don't have your patch here, did something go wrong with the submission? Only the cover letter seems to have made it through ... -Daniel > > include/drm/drm_atomic_helper.h | 33 +++++++++++++++++++++++++++++++++ > 1 file changed, 33 insertions(+) > > -- > Mihail Atanassov > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch