From: Thomas Garnier <thgarnie@google.com>
To: "Dave Hansen" <dave.hansen@intel.com>,
"Arnd Bergmann" <arnd@arndb.de>,
"René Nyffenegger" <mail@renenyffenegger.ch>,
"Stephen Bates" <stephen.bates@pmcs.com>,
"Jeff Moyer" <jmoyer@redhat.com>,
"Milosz Tanski" <milosz@adfin.com>,
"Thomas Garnier" <thgarnie@google.com>
Cc: linux-api@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-hardening@lists.openwall.com
Subject: [RFC] syscalls: Restore address limit after a syscall
Date: Thu, 9 Feb 2017 10:33:58 -0800 [thread overview]
Message-ID: <20170209183358.103094-1-thgarnie@google.com> (raw)
This patch prevents a syscall to modify the address limit of the
caller. The address limit is kept by the syscall wrapper and restored
just after the syscall ends.
For example, it would mitigation this bug:
- https://bugs.chromium.org/p/project-zero/issues/detail?id=990
Signed-off-by: Thomas Garnier <thgarnie@google.com>
---
Based on next-20170209
---
include/linux/syscalls.h | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/linux/syscalls.h b/include/linux/syscalls.h
index 91a740f6b884..a1b6a62a9849 100644
--- a/include/linux/syscalls.h
+++ b/include/linux/syscalls.h
@@ -198,7 +198,10 @@ extern struct trace_event_functions exit_syscall_print_funcs;
asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)); \
asmlinkage long SyS##name(__MAP(x,__SC_LONG,__VA_ARGS__)) \
{ \
- long ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \
+ long ret; \
+ mm_segment_t fs = get_fs(); \
+ ret = SYSC##name(__MAP(x,__SC_CAST,__VA_ARGS__)); \
+ set_fs(fs); \
__MAP(x,__SC_TEST,__VA_ARGS__); \
__PROTECT(x, ret,__MAP(x,__SC_ARGS,__VA_ARGS__)); \
return ret; \
--
2.11.0.483.g087da7b7c-goog
next reply other threads:[~2017-02-09 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 18:33 Thomas Garnier [this message]
2017-02-09 19:31 ` Kees Cook
2017-02-09 23:05 ` Andy Lutomirski
2017-02-09 23:41 ` Thomas Garnier
2017-02-10 2:42 ` Andy Lutomirski
2017-02-10 19:22 ` Russell King - ARM Linux
2017-02-10 20:49 ` Kees Cook
2017-02-10 21:49 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209183358.103094-1-thgarnie@google.com \
--to=thgarnie@google.com \
--cc=arnd@arndb.de \
--cc=dave.hansen@intel.com \
--cc=jmoyer@redhat.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@renenyffenegger.ch \
--cc=milosz@adfin.com \
--cc=stephen.bates@pmcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®