From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753524AbdBITVj (ORCPT ); Thu, 9 Feb 2017 14:21:39 -0500 Received: from mx2.suse.de ([195.135.220.15]:42815 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787AbdBITVf (ORCPT ); Thu, 9 Feb 2017 14:21:35 -0500 Date: Thu, 9 Feb 2017 20:20:47 +0100 From: Michal Hocko To: Maxime Ripard Cc: Rob Herring , Mark Rutland , Chen-Yu Tsai , Greg Kroah-Hartman , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, Thomas Petazzoni , Joonsoo Kim , m.szyprowski@samsung.com Subject: Re: [PATCH 3/8] mm: cma: Export a few symbols Message-ID: <20170209192046.GB31906@dhcp22.suse.cz> References: <2dee6c0baaf08e2c7d48ceb7e97e511c914d0f87.1486655917.git-series.maxime.ripard@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2dee6c0baaf08e2c7d48ceb7e97e511c914d0f87.1486655917.git-series.maxime.ripard@free-electrons.com> User-Agent: Mutt/1.6.0 (2016-04-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [CC CMA people] On Thu 09-02-17 17:39:17, Maxime Ripard wrote: > Modules might want to check their CMA pool size and address for debugging > and / or have additional checks. > > The obvious way to do this would be through dev_get_cma_area and > cma_get_base and cma_get_size, that are currently not exported, which > results in a build failure. > > Export them to prevent such a failure. Who actually uses those exports. None of the follow up patches does AFAICS. > Signed-off-by: Maxime Ripard > --- > drivers/base/dma-contiguous.c | 1 + > mm/cma.c | 2 ++ > 2 files changed, 3 insertions(+), 0 deletions(-) > > diff --git a/drivers/base/dma-contiguous.c b/drivers/base/dma-contiguous.c > index e167a1e1bccb..60f5c2591ccd 100644 > --- a/drivers/base/dma-contiguous.c > +++ b/drivers/base/dma-contiguous.c > @@ -35,6 +35,7 @@ > #endif > > struct cma *dma_contiguous_default_area; > +EXPORT_SYMBOL(dma_contiguous_default_area); > > /* > * Default global CMA area size can be defined in kernel's .config. > diff --git a/mm/cma.c b/mm/cma.c > index c960459eda7e..b50245282a18 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -47,11 +47,13 @@ phys_addr_t cma_get_base(const struct cma *cma) > { > return PFN_PHYS(cma->base_pfn); > } > +EXPORT_SYMBOL(cma_get_base); > > unsigned long cma_get_size(const struct cma *cma) > { > return cma->count << PAGE_SHIFT; > } > +EXPORT_SYMBOL(cma_get_size); > > static unsigned long cma_bitmap_aligned_mask(const struct cma *cma, > int align_order) > -- > git-series 0.8.11 > > -- > To unsubscribe, send a message with 'unsubscribe linux-mm' in > the body to majordomo@kvack.org. For more info on Linux MM, > see: http://www.linux-mm.org/ . > Don't email: email@kvack.org -- Michal Hocko SUSE Labs