From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932226AbdBJTpY (ORCPT ); Fri, 10 Feb 2017 14:45:24 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:47100 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932187AbdBJTpX (ORCPT ); Fri, 10 Feb 2017 14:45:23 -0500 Date: Fri, 10 Feb 2017 14:45:21 -0500 (EST) Message-Id: <20170210.144521.1768411194584186345.davem@davemloft.net> To: ivan.khoronzhuk@linaro.org Cc: w-kwok2@ti.com, m-karicheri2@ti.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: ethernet: ti: netcp_core: return netdev_tx_t in xmit From: David Miller In-Reply-To: <1486650254-8976-1-git-send-email-ivan.khoronzhuk@linaro.org> References: <1486650254-8976-1-git-send-email-ivan.khoronzhuk@linaro.org> X-Mailer: Mew version 6.7 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Fri, 10 Feb 2017 10:46:24 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ivan Khoronzhuk Date: Thu, 9 Feb 2017 16:24:14 +0200 > @@ -1300,7 +1301,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev) > dev_warn(netcp->ndev_dev, "padding failed (%d), packet dropped\n", > ret); > tx_stats->tx_dropped++; > - return ret; > + return NETDEV_TX_BUSY; > } > skb->len = NETCP_MIN_PACKET_SIZE; > } > @@ -1329,7 +1330,7 @@ static int netcp_ndo_start_xmit(struct sk_buff *skb, struct net_device *ndev) > if (desc) > netcp_free_tx_desc_chain(netcp, desc, sizeof(*desc)); > dev_kfree_skb(skb); > - return ret; > + return NETDEV_TX_BUSY; > } I really think these should be returning NET_XMIT_DROP.