From: Steffen Klassert <steffen.klassert@secunet.com>
To: Florian Westphal <fw@strlen.de>
Cc: <netdev@vger.kernel.org>, <dvyukov@google.com>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH ipsec] xfrm: policy: init locks early
Date: Fri, 10 Feb 2017 08:35:40 +0100 [thread overview]
Message-ID: <20170210073540.GY30338@gauss.secunet.com> (raw)
In-Reply-To: <20170208105229.27285-1-fw@strlen.de>
On Wed, Feb 08, 2017 at 11:52:29AM +0100, Florian Westphal wrote:
> Dmitry reports following splat:
> INFO: trying to register non-static key.
> the code is fine but needs lockdep annotation.
> turning off the locking correctness validator.
> CPU: 0 PID: 13059 Comm: syz-executor1 Not tainted 4.10.0-rc7-next-20170207 #1
> [..]
> spin_lock_bh include/linux/spinlock.h:304 [inline]
> xfrm_policy_flush+0x32/0x470 net/xfrm/xfrm_policy.c:963
> xfrm_policy_fini+0xbf/0x560 net/xfrm/xfrm_policy.c:3041
> xfrm_net_init+0x79f/0x9e0 net/xfrm/xfrm_policy.c:3091
> ops_init+0x10a/0x530 net/core/net_namespace.c:115
> setup_net+0x2ed/0x690 net/core/net_namespace.c:291
> copy_net_ns+0x26c/0x530 net/core/net_namespace.c:396
> create_new_namespaces+0x409/0x860 kernel/nsproxy.c:106
> unshare_nsproxy_namespaces+0xae/0x1e0 kernel/nsproxy.c:205
> SYSC_unshare kernel/fork.c:2281 [inline]
>
> Problem is that when we get error during xfrm_net_init we will call
> xfrm_policy_fini which will acquire xfrm_policy_lock before it was
> initialized. Just move it around so locks get set up first.
>
> Reported-by: Dmitry Vyukov <dvyukov@google.com>
> Fixes: 283bc9f35bbbcb0e9 ("xfrm: Namespacify xfrm state/policy locks")
> Signed-off-by: Florian Westphal <fw@strlen.de>
Applied, thanks everyone!
prev parent reply other threads:[~2017-02-10 7:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 10:24 net/xfrm: use of uninit spinlock in xfrm_policy_flush Dmitry Vyukov
2017-02-08 10:52 ` [PATCH ipsec] xfrm: policy: init locks early Florian Westphal
2017-02-10 7:35 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210073540.GY30338@gauss.secunet.com \
--to=steffen.klassert@secunet.com \
--cc=dvyukov@google.com \
--cc=fw@strlen.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®