From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751837AbdBJHrb (ORCPT ); Fri, 10 Feb 2017 02:47:31 -0500 Received: from mga11.intel.com ([192.55.52.93]:43590 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751925AbdBJHr3 (ORCPT ); Fri, 10 Feb 2017 02:47:29 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,139,1484035200"; d="scan'208";a="63037876" Date: Fri, 10 Feb 2017 09:42:12 +0200 From: Jarkko Sakkinen To: Jason Gunthorpe Cc: tpmdd-devel@lists.sourceforge.net, linux-security-module@vger.kernel.org, Peter Huewe , Marcel Selhorst , open list Subject: Re: [PATCH 2/6] tpm: export tpm2_flush_context_cmd Message-ID: <20170210074212.pi7xb4rvjuwfkdj7@intel.com> References: <20170208110713.14070-1-jarkko.sakkinen@linux.intel.com> <20170208110713.14070-3-jarkko.sakkinen@linux.intel.com> <20170208175830.GA31571@obsidianresearch.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170208175830.GA31571@obsidianresearch.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 10:58:30AM -0700, Jason Gunthorpe wrote: > > /** > > + * tpm2_flush_context_cmd() - execute a TPM2_FlushContext command > > + * @chip: TPM chip to use > > + * @payload: the key data in clear and encrypted form > > + * @options: authentication values and other options > > + * > > + * Return: same as with tpm_transmit_cmd > > + */ > > +void tpm2_flush_context_cmd(struct tpm_chip *chip, u32 handle, > > + unsigned int flags) > > Why did you move the function in the same file? Adding a prototype > shouldn't require that.. > > Jason To be logically positioned in the same way as it is in the header. It cannot in-between the helper functions for tpm2_seal_trusted(). /Jarkko