From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751912AbdBJHtH (ORCPT ); Fri, 10 Feb 2017 02:49:07 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:41514 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751445AbdBJHtG (ORCPT ); Fri, 10 Feb 2017 02:49:06 -0500 Date: Fri, 10 Feb 2017 07:47:16 +0000 From: Al Viro To: Konstantin Khlebnikov Cc: linux-kernel@vger.kernel.org, Andrew Morton , "Eric W. Biederman" Subject: Re: [PATCH] proc/sysctl: prune stale dentries during unregistering Message-ID: <20170210074715.GN13195@ZenIV.linux.org.uk> References: <20170209084016.GL13195@ZenIV.linux.org.uk> <148671210259.52694.13774349516906955456.stgit@buzz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148671210259.52694.13774349516906955456.stgit@buzz> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2017 at 10:35:02AM +0300, Konstantin Khlebnikov wrote: > # time sysctl -a > /dev/null > real 1m12.806s > user 0m0.016s > sys 1m12.400s > > Currently only memory reclaimer could remove this garbage. > But without significant memory pressure this never happens. > > This patch collects sysctl inodes into list on sysctl table header and > prunes all their dentries once that table unregisters. I'd probably go for hlist, but that's mostly cosmetic difference; how about the matching stats *after* that patch?