From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751964AbdBJJWZ (ORCPT ); Fri, 10 Feb 2017 04:22:25 -0500 Received: from mga14.intel.com ([192.55.52.115]:61719 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbdBJJWX (ORCPT ); Fri, 10 Feb 2017 04:22:23 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,140,1484035200"; d="scan'208";a="1124694807" Date: Fri, 10 Feb 2017 10:52:56 +0200 From: Jarkko Sakkinen To: tpmdd-devel@lists.sourceforge.net Cc: linux-security-module@vger.kernel.org, James Bottomley , Peter Huewe , Marcel Selhorst , Jason Gunthorpe , open list Subject: Re: [PATCH 6/6] tpm2: add session handle context saving and restoring to the space code Message-ID: <20170210085256.eqhnrmdug2fcz4ql@intel.com> References: <20170208110713.14070-1-jarkko.sakkinen@linux.intel.com> <20170208110713.14070-7-jarkko.sakkinen@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170208110713.14070-7-jarkko.sakkinen@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 08, 2017 at 01:07:08PM +0200, Jarkko Sakkinen wrote: > + rc = tpm2_load_context(chip, space->session_buf, > + &offset, &handle); > + if (rc == -ENOENT) { > + /* load failed, just forget session */ > + space->session_tbl[i] = 0; This is my only concern in this commit. Should we also in this case just flush the space or not? /Jarkko