From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: timers: Make flags output in the timer_start tracepoint useful
Date: Fri, 10 Feb 2017 09:19:21 -0500 [thread overview]
Message-ID: <20170210091921.68f7ca19@gandalf.local.home> (raw)
In-Reply-To: <alpine.DEB.2.20.1702101420450.4036@nanos>
On Fri, 10 Feb 2017 14:25:03 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:
> The timer flags in the timer_start trace event contain lots of useful
> information, but the meaning is not clear in the trace output because its
> just printed as a hex value. Making tools rely on the bit positions is bad
> as they might change over time.
>
> Decode the flags in the printout. Tools can retrieve the bits and their
> meaning from the trace format file.
>
> Example output:
> kworker/2:1-47 <SNIP> [timeout=592] cpu=2 idx=170 flags=D|I
>
> So the timer is Deferrable and Interruptsafe, queued on CPU 2 into bucket
> 170.
>
> Requested-by: Arjan van de Ven <arjan@linux.intel.com>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> include/trace/events/timer.h | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> --- a/include/trace/events/timer.h
> +++ b/include/trace/events/timer.h
> @@ -36,6 +36,13 @@ DEFINE_EVENT(timer_class, timer_init,
> TP_ARGS(timer)
> );
>
> +#define decode_timer_flags(flags) \
> + __print_flags(flags, "|", \
> + { TIMER_MIGRATING, "M" }, \
> + { TIMER_DEFERRABLE, "D" }, \
> + { TIMER_PINNED, "P" }, \
> + { TIMER_IRQSAFE, "I" })
> +
> /**
> * timer_start - called when the timer is started
> * @timer: pointer to struct timer_list
> @@ -65,9 +72,12 @@ TRACE_EVENT(timer_start,
> __entry->flags = flags;
> ),
>
> - TP_printk("timer=%p function=%pf expires=%lu [timeout=%ld] flags=0x%08x",
> + TP_printk("timer=%p function=%pf expires=%lu [timeout=%ld] cpu=%u idx=%u flags=%s",
> __entry->timer, __entry->function, __entry->expires,
> - (long)__entry->expires - __entry->now, __entry->flags)
> + (long)__entry->expires - __entry->now,
> + __entry->flags & TIMER_CPUMASK,
> + __entry->flags >> TIMER_ARRAYSHIFT,
> + decode_timer_flags(__entry->flags & TIMER_TRACE_FLAGMASK))
Hi Thomas,
This all looks good, but I can't find TIMER_TRACE_FLAGMASK. Was that
added by another patch?
-- Steve
> );
>
> /**
next prev parent reply other threads:[~2017-02-10 14:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 13:25 Thomas Gleixner
2017-02-10 14:19 ` Steven Rostedt [this message]
2017-02-10 14:37 ` Thomas Gleixner
2017-02-10 14:51 ` Steven Rostedt
2017-02-10 15:28 ` Thomas Gleixner
2017-02-10 15:41 ` [PATCH V2] " Thomas Gleixner
2017-02-10 16:11 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210091921.68f7ca19@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®