From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753258AbdBJOvl (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Feb 2017 09:51:41 -0500
Received: from mail.kernel.org ([198.145.29.136]:54522 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752179AbdBJOvj (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Feb 2017 09:51:39 -0500
Date: Fri, 10 Feb 2017 09:51:35 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Thomas Gleixner <tglx@linutronix.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <peterz@infradead.org>,
        Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: timers: Make flags output in the timer_start tracepoint useful
Message-ID: <20170210095135.45671d44@gandalf.local.home>
In-Reply-To: <alpine.DEB.2.20.1702101536451.4036@nanos>
References: <alpine.DEB.2.20.1702101420450.4036@nanos>
        <20170210091921.68f7ca19@gandalf.local.home>
        <alpine.DEB.2.20.1702101536451.4036@nanos>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 10 Feb 2017 15:37:11 +0100 (CET)
Thomas Gleixner <tglx@linutronix.de> wrote:

> > > --- a/include/trace/events/timer.h
> > > +++ b/include/trace/events/timer.h
> > > @@ -36,6 +36,13 @@ DEFINE_EVENT(timer_class, timer_init,
> > >  	TP_ARGS(timer)
> > >  );
> > >  
> > > +#define decode_timer_flags(flags)			\
> > > +	__print_flags(flags, "|",			\
> > > +		{  TIMER_MIGRATING,	"M" },		\
> > > +		{  TIMER_DEFERRABLE,	"D" },		\
> > > +		{  TIMER_PINNED,	"P" },		\
> > > +		{  TIMER_IRQSAFE,	"I" })
> > > +
> > >  /**
> > >   * timer_start - called when the timer is started
> > >   * @timer:	pointer to struct timer_list
> > > @@ -65,9 +72,12 @@ TRACE_EVENT(timer_start,
> > >  		__entry->flags		= flags;
> > >  	),
> > >  
> > > -	TP_printk("timer=%p function=%pf expires=%lu [timeout=%ld] flags=0x%08x",
> > > +	TP_printk("timer=%p function=%pf expires=%lu [timeout=%ld] cpu=%u idx=%u flags=%s",
> > >  		  __entry->timer, __entry->function, __entry->expires,
> > > -		  (long)__entry->expires - __entry->now, __entry->flags)
> > > +		  (long)__entry->expires - __entry->now,
> > > +		  __entry->flags & TIMER_CPUMASK,
> > > +		  __entry->flags >> TIMER_ARRAYSHIFT,
> > > +		  decode_timer_flags(__entry->flags & TIMER_TRACE_FLAGMASK))  
> > 
> > Hi Thomas,
> > 
> > This all looks good, but I can't find TIMER_TRACE_FLAGMASK. Was that
> > added by another patch?  
> 
> -ENO_QUILT_REFRESH ....

I'm wondering if it wouldn't just make sense to add another mask in
include/linux/timer.h along with the other TIMER macros?

#define TIMER_TYPEMASK	0x003C0000

Or some other name?

-- Steve