From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753652AbdBJTBJ (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Feb 2017 14:01:09 -0500
Received: from mail.kernel.org ([198.145.29.136]:37468 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1753791AbdBJTBH (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Feb 2017 14:01:07 -0500
Date: Fri, 10 Feb 2017 14:01:01 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jason Baron <jbaron@akamai.com>,
        Peter Zijlstra <peterz@infradead.org>, Borislav Petkov <bp@alien8.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        Thomas Gleixner <tglx@linutronix.de>, Mel Gorman <mgorman@suse.de>,
        Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] jump_label: don't export section tags
Message-ID: <20170210140101.5a717ec4@gandalf.local.home>
In-Reply-To: <1486747774-16505-1-git-send-email-mst@redhat.com>
References: <1486747774-16505-1-git-send-email-mst@redhat.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 10 Feb 2017 19:29:44 +0200
"Michael S. Tsirkin" <mst@redhat.com> wrote:

> These are supplied by the linker and only used by jump_label.c.
> This trivial patch moves them out of jump_label.h.
> 
> Cc: Jason Baron <jbaron@akamai.com>
> Cc: Peter Zijlstra <peterz@infradead.org>
> Cc: Steven Rostedt <rostedt@goodmis.org>
> Cc: Borislav Petkov <bp@alien8.de>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: Linus Torvalds <torvalds@linux-foundation.org>
> Cc: Thomas Gleixner <tglx@linutronix.de>
> Cc: Mel Gorman <mgorman@suse.de>
> Cc: Ingo Molnar <mingo@kernel.org>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> ---
>  include/linux/jump_label.h | 3 ---
>  kernel/jump_label.c        | 4 ++++
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/jump_label.h b/include/linux/jump_label.h
> index 48ed83f..21701da 100644
> --- a/include/linux/jump_label.h
> +++ b/include/linux/jump_label.h
> @@ -132,9 +132,6 @@ static __always_inline bool static_key_true(struct static_key *key)
>  	return !arch_static_branch(key, true);
>  }
>  
> -extern const struct jump_entry __start___jump_table[];
> -extern const struct jump_entry __stop___jump_table[];
> -
>  extern void jump_label_init(void);
>  extern void jump_label_lock(void);
>  extern void jump_label_unlock(void);
> diff --git a/kernel/jump_label.c b/kernel/jump_label.c
> index a9b8cf5..6eaa84c 100644
> --- a/kernel/jump_label.c
> +++ b/kernel/jump_label.c
> @@ -18,6 +18,10 @@
>  
>  #ifdef HAVE_JUMP_LABEL
>  
> +/* Supplied by a linker script */

This is common practice and obvious to anyone that does a git grep. I
don't really think the comment is necessary.

But the change itself is fine.

Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>

-- Steve

> +extern struct jump_entry __start___jump_table[];
> +extern struct jump_entry __stop___jump_table[];
> +
>  /* mutex to protect coming/going of the the jump_label table */
>  static DEFINE_MUTEX(jump_label_mutex);
>