From: Wolfram Sang <wsa@the-dreams.de>
To: Ben Gardner <gardner.ben@gmail.com>
Cc: linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org,
Andy Shevchenko <andy.shevchenko@gmail.com>
Subject: Re: [PATCH v4] eeprom/at24: use device_property_*() functions instead of of_get_property()
Date: Fri, 10 Feb 2017 16:34:17 +0100 [thread overview]
Message-ID: <20170210153416.lrjyq5i2p7axyxfj@ninjato> (raw)
In-Reply-To: <1486661768-21456-1-git-send-email-gardner.ben@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1320 bytes --]
On Thu, Feb 09, 2017 at 11:36:08AM -0600, Ben Gardner wrote:
> Allow the at24 driver to get configuration information from both OF and
> ACPI by using the more generic device_property functions.
> This change was inspired by the at25.c driver.
>
> I have a custom board with a ST M24C02 EEPROM attached to an I2C bus.
> With the following ACPI construct, this patch instantiates a working
> instance of the driver.
>
> Device (EEP0) {
> Name (_HID, "PRP0001")
> Name (_DSD, Package () {
> ToUUID("daffd814-6eba-4d8c-8a91-bc9bbf4aa301"),
> Package () {
> Package () {"compatible", Package () {"st,24c02"}},
> Package () {"pagesize", 16},
> },
> })
> Name (_CRS, ResourceTemplate () {
> I2cSerialBus (
> 0x0057, ControllerInitiated, 400000,
> AddressingMode7Bit, "\\_SB.PCI0.I2C3", 0x00,
> ResourceConsumer,,)
> })
> }
>
> Note: Matching the driver to the I2C device requires another patch.
> http://www.spinics.net/lists/linux-acpi/msg71914.html
This should have been below the "---" because dependencies are not
relevant in the git history.
>
> Signed-off-by: Ben Gardner <gardner.ben@gmail.com>
Please send new patches not in-reply-to old patches, seperate threads
are easier to find IMHO.
Other than that:
Applied to for-next, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-02-10 15:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-08 19:53 [PATCH] " Ben Gardner
2017-02-09 0:07 ` Andy Shevchenko
2017-02-09 15:27 ` Ben Gardner
2017-02-09 15:33 ` [PATCH v2] " Ben Gardner
2017-02-09 16:20 ` Andy Shevchenko
2017-02-09 17:03 ` Ben Gardner
2017-02-09 17:09 ` [PATCH v3] " Ben Gardner
2017-02-09 17:18 ` Ben Gardner
2017-02-09 17:36 ` [PATCH v4] " Ben Gardner
2017-02-09 17:43 ` Andy Shevchenko
2017-02-09 19:58 ` Wolfram Sang
2017-02-09 20:31 ` Ben Gardner
2017-02-10 15:34 ` Wolfram Sang [this message]
2017-02-09 20:35 ` [PATCH v2] " kbuild test robot
2017-02-09 21:30 ` Andy Shevchenko
2017-02-09 23:52 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210153416.lrjyq5i2p7axyxfj@ninjato \
--to=wsa@the-dreams.de \
--cc=andy.shevchenko@gmail.com \
--cc=gardner.ben@gmail.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®