From: Namhyung Kim <namhyung@kernel.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ingo Molnar <mingo@kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Peter Zijlstra <peterz@infradead.org>,
Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
"H . Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH V2 2/2] tracing/probe: Show subsystem name in messages
Date: Sat, 11 Feb 2017 01:01:55 +0900 [thread overview]
Message-ID: <20170210160155.GA17906@danjae.aot.lge.com> (raw)
In-Reply-To: <148673297629.2579.7379973048544040492.stgit@devbox>
On Fri, Feb 10, 2017 at 10:23:06PM +0900, Masami Hiramatsu wrote:
> Show "trace_probe:", "trace_kprobe:" and "trace_uprobe:"
> headers for each warning/error/info message. This will
> help people to notice that kprobe/uprobe events caused
> those messages.
>
> Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> ---
> kernel/trace/trace_kprobe.c | 1 +
> kernel/trace/trace_probe.c | 1 +
> kernel/trace/trace_uprobe.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
> index d3729bd..5f688cc 100644
> --- a/kernel/trace/trace_kprobe.c
> +++ b/kernel/trace/trace_kprobe.c
> @@ -16,6 +16,7 @@
> * along with this program; if not, write to the Free Software
> * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
> */
> +#define pr_fmt(fmt) "trace_kprobe: " fmt
>
> #include <linux/module.h>
> #include <linux/uaccess.h>
> diff --git a/kernel/trace/trace_probe.c b/kernel/trace/trace_probe.c
> index 847c1e0..52478f0 100644
> --- a/kernel/trace/trace_probe.c
> +++ b/kernel/trace/trace_probe.c
> @@ -21,6 +21,7 @@
> * Copyright (C) IBM Corporation, 2010-2011
> * Author: Srikar Dronamraju
> */
> +#define pr_fmt(fmt) "trace_probe: " fmt
>
> #include "trace_probe.h"
>
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index e5445ab..2c6b2d0c 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -17,6 +17,7 @@
> * Copyright (C) IBM Corporation, 2010-2012
> * Author: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> */
> +#define pr_fmt(fmt) "trace_kprobe: " fmt
s/kprobe/uprobe/ ?
Thanks,
Namhyung
>
> #include <linux/module.h>
> #include <linux/uaccess.h>
>
next prev parent reply other threads:[~2017-02-10 16:08 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 23:04 [RFC][PATCH] tracing: Have traceprobe_probes_write() not access userspace unnecessarily Steven Rostedt
2017-02-10 5:50 ` Masami Hiramatsu
2017-02-10 7:53 ` Ingo Molnar
2017-02-10 10:37 ` Masami Hiramatsu
2017-02-10 14:05 ` Steven Rostedt
2017-02-10 13:21 ` [PATCH V2 1/2] tracing/probes: Fix a warning message to show correct maximum length Masami Hiramatsu
2017-02-10 16:04 ` Steven Rostedt
2017-02-15 15:10 ` Masami Hiramatsu
2017-02-15 15:31 ` Steven Rostedt
2017-02-10 13:23 ` [PATCH V2 2/2] tracing/probe: Show subsystem name in messages Masami Hiramatsu
2017-02-10 16:01 ` Namhyung Kim [this message]
2017-02-10 16:17 ` Steven Rostedt
2017-02-10 22:35 ` Masami Hiramatsu
2017-02-10 22:36 ` [PATCH V3] " Masami Hiramatsu
2017-02-10 6:20 ` [RFC][PATCH] tracing: Have traceprobe_probes_write() not access userspace unnecessarily Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170210160155.GA17906@danjae.aot.lge.com \
--to=namhyung@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=ananth@linux.vnet.ibm.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mhiramat@kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®