From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752380AbdBKAWT (ORCPT ); Fri, 10 Feb 2017 19:22:19 -0500 Received: from mail-pf0-f179.google.com ([209.85.192.179]:34213 "EHLO mail-pf0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751430AbdBKAWR (ORCPT ); Fri, 10 Feb 2017 19:22:17 -0500 Date: Fri, 10 Feb 2017 16:22:08 -0800 From: Stephen Hemminger To: Shannon Nelson Cc: netdev@vger.kernel.org, davem@davemloft.net, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support Message-ID: <20170210162208.69485824@xeon-e3> In-Reply-To: <1486748305-240339-5-git-send-email-shannon.nelson@oracle.com> References: <1486748305-240339-1-git-send-email-shannon.nelson@oracle.com> <1486748305-240339-5-git-send-email-shannon.nelson@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 10 Feb 2017 09:38:20 -0800 Shannon Nelson wrote: > +static void vsw_get_ethtool_stats(struct net_device *dev, > + struct ethtool_stats *estats, u64 *data) > +{ > + int i = 0; > + > + data[i++] = dev->stats.rx_packets; > + data[i++] = dev->stats.tx_packets; > + data[i++] = dev->stats.rx_bytes; > + data[i++] = dev->stats.tx_bytes; > + data[i++] = dev->stats.rx_errors; > + data[i++] = dev->stats.tx_errors; > + data[i++] = dev->stats.rx_dropped; > + data[i++] = dev->stats.tx_dropped; > + data[i++] = dev->stats.multicast; Please do not duplicate regular network statistics into ethtool. This doesn't really add any value.