From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752384AbdBJRMo (ORCPT ); Fri, 10 Feb 2017 12:12:44 -0500 Received: from userp1050.oracle.com ([156.151.31.82]:38942 "EHLO userp1050.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751577AbdBJRMn (ORCPT ); Fri, 10 Feb 2017 12:12:43 -0500 Date: Fri, 10 Feb 2017 20:09:46 +0300 From: Dan Carpenter To: Carlos Palminha Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org Subject: Re: [PATCH v2] staging: rtl8712: rtl8712: fixed missing conversion to le32 Message-ID: <20170210170946.GB4162@mwanda> References: <20170209101842.13389-1-palminha@synopsys.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170209101842.13389-1-palminha@synopsys.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userp1040.oracle.com [156.151.31.81] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 09, 2017 at 10:18:42AM +0000, Carlos Palminha wrote: > Fixed missing conversion to le32, detected by sparse > (invalid assignment from int to __le32) > > Signed-off-by: Carlos Palminha > --- > v1->v2: > missed sob line (too late in the night...) > > drivers/staging/rtl8712/rtl8712_xmit.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8712/rtl8712_xmit.c b/drivers/staging/rtl8712/rtl8712_xmit.c > index 041508d6ec6d..4231a0a83097 100644 > --- a/drivers/staging/rtl8712/rtl8712_xmit.c > +++ b/drivers/staging/rtl8712/rtl8712_xmit.c > @@ -573,7 +573,7 @@ static void update_txdesc(struct xmit_frame *pxmitframe, uint *pmem, int sz) > } > } else if (pxmitframe->frame_tag == MGNT_FRAMETAG) { > /* offset 4 */ > - ptxdesc->txdw1 |= (0x05) & 0x1f;/*CAM_ID(MAC_ID), default=5;*/ > + ptxdesc->txdw1 |= cpu_to_le32((0x05) & 0x1f);/*CAM_ID(MAC_ID), default=5;*/ This looks reasonable but it's probably cleaner to say something like: ptxdesc->txdw1 |= cpu_to_le32(0x05); /*CAM_ID(MAC_ID), default=5;*/ regards, dan carpenter