From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753578AbdBJTjE (ORCPT <rfc822;w@1wt.eu>);
        Fri, 10 Feb 2017 14:39:04 -0500
Received: from pandora.armlinux.org.uk ([78.32.30.218]:58850 "EHLO
        pandora.armlinux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1753373AbdBJTjC (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 10 Feb 2017 14:39:02 -0500
Date: Fri, 10 Feb 2017 19:38:50 +0000
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Thibault Saunier <thibault.saunier@osg.samsung.com>
Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        Inki Dae <inki.dae@samsung.com>, Ulf Hansson <ulf.hansson@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, Shuah Khan <shuahkh@osg.samsung.com>,
        Andi Shyti <andi.shyti@samsung.com>,
        Mauro Carvalho Chehab <mchehab@s-opensource.com>,
        Javier Martinez Canillas <javier@osg.samsung.com>,
        Kukjin Kim <kgene@kernel.org>, Krzysztof Kozlowski <krzk@kernel.org>,
        Sylwester Nawrocki <s.nawrocki@samsung.com>,
        Nicolas Dufresne <nicolas.dufresne@collabora.com>,
        linux-samsung-soc@vger.kernel.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH v2 1/4] [media] exynos-gsc: Use 576p instead 720p as a
 threshold for colorspaces
Message-ID: <20170210193850.GN27312@n2100.armlinux.org.uk>
References: <20170209200420.3046-1-thibault.saunier@osg.samsung.com>
 <20170209200420.3046-2-thibault.saunier@osg.samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20170209200420.3046-2-thibault.saunier@osg.samsung.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Feb 09, 2017 at 05:04:17PM -0300, Thibault Saunier wrote:
> From: Javier Martinez Canillas <javier@osg.samsung.com>
> 
> The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace
> should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers
> don't agree on the display resolution that should be used as a threshold.
> 
> Some drivers set V4L2_COLORSPACE_REC709 for 720p and higher while others
> set V4L2_COLORSPACE_REC709 for anything higher than 576p. Newers drivers
> use the latter and that also matches what user-space multimedia programs
> do (i.e: GStreamer), so change the driver logic to be aligned with this.
> 
> Also, check for the resolution in G_FMT instead unconditionally setting
> the V4L2_COLORSPACE_REC709 colorspace.

It would be nice to refer to some specification to justify the change,
rather than "let's follow what <random-piece-of-software> does".

EIA CEA 861B talks about colorimetry for various resolutions:

5.1 480p, 480i, 576p, 576i, 240p, and 288p
The color space used by the 480-line, 576-line, 240-line, and 288-line
formats will likely be based on SMPTE 170M [1].

5.2 1080i, 1080p, and 720p
The color space used by the high definition formats will likely be based
on ITU-R BT.709-4 [6].

Notice, however, that it says "will likely be" - it's not a requirement,
as it's expected that the colorspace will be part of the media metadata
(eg, contained in the transport stream.)  In other words, it should be
configurable or ultimately provided by the ultimate source of the image.

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.