From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751326AbdBLCBE (ORCPT ); Sat, 11 Feb 2017 21:01:04 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:44258 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751076AbdBLCBC (ORCPT ); Sat, 11 Feb 2017 21:01:02 -0500 Date: Sat, 11 Feb 2017 21:01:01 -0500 (EST) Message-Id: <20170211.210101.1450332574457722492.davem@davemloft.net> To: stephen@networkplumber.org Cc: shannon.nelson@oracle.com, netdev@vger.kernel.org, sparclinux@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 net-next 4/9] sunvnet: add driver stats for ethtool support From: David Miller In-Reply-To: <20170210162208.69485824@xeon-e3> References: <1486748305-240339-1-git-send-email-shannon.nelson@oracle.com> <1486748305-240339-5-git-send-email-shannon.nelson@oracle.com> <20170210162208.69485824@xeon-e3> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 11 Feb 2017 17:02:04 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Stephen Hemminger Date: Fri, 10 Feb 2017 16:22:08 -0800 > On Fri, 10 Feb 2017 09:38:20 -0800 > Shannon Nelson wrote: > >> +static void vsw_get_ethtool_stats(struct net_device *dev, >> + struct ethtool_stats *estats, u64 *data) >> +{ >> + int i = 0; >> + >> + data[i++] = dev->stats.rx_packets; >> + data[i++] = dev->stats.tx_packets; >> + data[i++] = dev->stats.rx_bytes; >> + data[i++] = dev->stats.tx_bytes; >> + data[i++] = dev->stats.rx_errors; >> + data[i++] = dev->stats.tx_errors; >> + data[i++] = dev->stats.rx_dropped; >> + data[i++] = dev->stats.tx_dropped; >> + data[i++] = dev->stats.multicast; > > Please do not duplicate regular network statistics into ethtool. > This doesn't really add any value. Agreed.