From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753638AbdBKKP6 (ORCPT ); Sat, 11 Feb 2017 05:15:58 -0500 Received: from 92-243-34-74.adsl.nanet.at ([92.243.34.74]:50192 "EHLO mail.osadl.at" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1751009AbdBKKP5 (ORCPT ); Sat, 11 Feb 2017 05:15:57 -0500 Date: Sat, 11 Feb 2017 10:15:43 +0000 From: Nicholas Mc Guire To: Herbert Xu Cc: "David S. Miller" , Russell King , linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] crypto: arm/aes-ce: assign err return conditionally Message-ID: <20170211101543.GC13432@osadl.at> References: <1486560979-25240-1-git-send-email-der.herr@hofr.at> <20170211093946.GA749@gondor.apana.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170211093946.GA749@gondor.apana.org.au> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Feb 11, 2017 at 05:39:46PM +0800, Herbert Xu wrote: > On Wed, Feb 08, 2017 at 02:36:19PM +0100, Nicholas Mc Guire wrote: > > As the err value is not used unless there was an error it can be assigned > > conditionally here. > > > > Signed-off-by: Nicholas Mc Guire > > This patch just adds noise to the commit history. So I'm not going > to apply it. ok - I was not sure about how sensible this sort of changes are either - will drop those code-to-object refactoring experiments then again. thx! hofrat