From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbdBNC6T (ORCPT ); Mon, 13 Feb 2017 21:58:19 -0500 Received: from shards.monkeyblade.net ([184.105.139.130]:55128 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751176AbdBNC6S (ORCPT ); Mon, 13 Feb 2017 21:58:18 -0500 Date: Mon, 13 Feb 2017 21:58:11 -0500 (EST) Message-Id: <20170213.215811.902501442022534048.davem@davemloft.net> To: keescook@chromium.org Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk, corbet@lwn.net, tim@cyberelk.net, bp@alien8.de, jejb@linux.vnet.ibm.com, martin.petersen@oracle.com, linux-doc@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, kernel-hardening@lists.openwall.com Subject: Re: [PATCH] cdrom: Make device operations read-only From: David Miller In-Reply-To: <20170214002526.GA124769@beast> References: <20170214002526.GA124769@beast> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 13 Feb 2017 17:59:19 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kees Cook Date: Mon, 13 Feb 2017 16:25:26 -0800 > diff --git a/drivers/ide/ide-cd.c b/drivers/ide/ide-cd.c > index 9cbd217bc0c9..ab9232e1e16f 100644 > --- a/drivers/ide/ide-cd.c > +++ b/drivers/ide/ide-cd.c > @@ -1166,7 +1166,7 @@ void ide_cdrom_update_speed(ide_drive_t *drive, u8 *buf) > CDC_CD_RW | CDC_DVD | CDC_DVD_R | CDC_DVD_RAM | CDC_GENERIC_PACKET | \ > CDC_MO_DRIVE | CDC_MRW | CDC_MRW_W | CDC_RAM) > > -static struct cdrom_device_ops ide_cdrom_dops = { > +static const struct cdrom_device_ops ide_cdrom_dops = { > .open = ide_cdrom_open_real, > .release = ide_cdrom_release_real, > .drive_status = ide_cdrom_drive_status, Acked-by: David S. Miller