From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbdBMF4A (ORCPT ); Mon, 13 Feb 2017 00:56:00 -0500 Received: from LGEAMRELO11.lge.com ([156.147.23.51]:51475 "EHLO lgeamrelo11.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751684AbdBMFz7 (ORCPT ); Mon, 13 Feb 2017 00:55:59 -0500 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Mon, 13 Feb 2017 14:55:36 +0900 From: Byungchul Park To: "Huang, Ying" Cc: peterz@infradead.org, mingo@kernel.org, koverstreet@google.com, neilb@suse.de, nab@linux-iscsi.org, viro@zeniv.linux.org.uk, oleg@redhat.com, asias@redhat.com, shli@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] llist: Don't reinvent the wheel but use existing llist API Message-ID: <20170213055535.GI16086@X58A-UD3R> References: <1486959013-26105-1-git-send-email-byungchul.park@lge.com> <87lgtatztv.fsf@yhuang-dev.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87lgtatztv.fsf@yhuang-dev.intel.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 13, 2017 at 01:38:36PM +0800, Huang, Ying wrote: > Hi, Byungchul, > > Byungchul Park writes: > > > Although llist provides proper APIs, they are not used. Make them used. > > > > Signed-off-by: Byungchul Park > > --- > > drivers/md/bcache/closure.c | 15 ++------------- > > drivers/md/raid5.c | 4 +--- > > drivers/vhost/scsi.c | 9 ++------- > > fs/file_table.c | 12 +++++------- > > fs/namespace.c | 12 +++++------- > > include/linux/llist.h | 3 +++ > > kernel/irq_work.c | 6 +----- > > kernel/sched/core.c | 13 ++----------- > > mm/vmalloc.c | 8 +++----- > > I think you need to split the patch. One for each subsystem, this makes > it easier to be reviewed and merged. Thank you. I will do it. > > Best Regards, > Huang, Ying > > [snip]