From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752466AbdBMIOx (ORCPT ); Mon, 13 Feb 2017 03:14:53 -0500 Received: from mail.free-electrons.com ([62.4.15.54]:46053 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbdBMIOt (ORCPT ); Mon, 13 Feb 2017 03:14:49 -0500 Date: Mon, 13 Feb 2017 09:14:47 +0100 From: Maxime Ripard To: Priit Laes Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, Jonathan Liu , Thierry Reding , Russell King , Chen-Yu Tsai , Mark Rutland , Rob Herring , David Airlie , Quentin Schulz , linux-sunxi@googlegroups.com Subject: Re: [PATCH 4/8] drm/sun4i: Add optional 'mode' property to TCON Message-ID: <20170213081447.r2jhkcx3ex5tsspi@lukather> References: <20170211174405.28395-1-plaes@plaes.org> <20170211174405.28395-5-plaes@plaes.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="tr7rxvx6c4gh5lyu" Content-Disposition: inline In-Reply-To: <20170211174405.28395-5-plaes@plaes.org> User-Agent: Mutt/1.6.2-neo (2016-08-21) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --tr7rxvx6c4gh5lyu Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Sat, Feb 11, 2017 at 07:44:01PM +0200, Priit Laes wrote: > Add variable to enable either 'rgb' or 'lvds' output. >=20 > Signed-off-by: Priit Laes > --- > Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt | 3 +++ > 1 file changed, 3 insertions(+) >=20 > diff --git a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.tx= t b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > index b82c004..c367ede 100644 > --- a/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > +++ b/Documentation/devicetree/bindings/display/sunxi/sun4i-drm.txt > @@ -43,6 +43,9 @@ Required properties: > - reset-names: the reset names mentioned above > - clock-output-names: Name of the pixel clock created > =20 > +- mode: Defines which encoder will be enabled. Values are 'rgb', 'lvds'. > + Defaults to 'rgb' if not set. > + Unfortunately, this won't really work. You could very well have two panels and switch from one to another by changing the pin muxing, so we have to use an enpoint for that. This is pretty much the same case that we have with the A10s where we need to have two output endpoints for the TV Encoder and HDMI, something we cannot support right now in our binding, since we assume that we have the two channels that only have one user, which turned out to be wrong. I guess an easy way would be to have an extra property defining which channel the endpoint is attached to. Thanks, Maxime --=20 Maxime Ripard, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com --tr7rxvx6c4gh5lyu Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJYoWrzAAoJEBx+YmzsjxAgtW4P/2Uq74KZDUKAKdiYNNddUvAK 48FKdS1Ah1R6f7IEfMLK7w+4E+QWCo0BtpfBvY7vTFsaZRiZnk7Yzt587RXBiE1H 6Kqpbb/eGsNZe12Oth+/nCxUrnOC7z56X6YRTyAmKBFpUL7AOP1qeGV/b7+cbOOI 1U+WTAwZjbJVAfp6Bg4J7ELbem5Nr2XxSdlmvMRBpiqkTGteT7DfHtx0HiBfcpzv WtaKPp7QAbayewoegiSCsHefpxx+4rEezIdXf9/A2ckeQKhUAgdJyRl1SVtP/RJI Mv3dkb/uvd5O/w1myAQYIhceM+ObFhu6CR5D0bY9em6M7TiLu1KqfKl8lKiQ8UtK NhDTV1qIMcoAXqGSs+QmT6B7i+GKbDbFcJRksz/gXMvjtS7H8+ohsccs1ZQyJTH0 91IUj9mNTV8fB45cAj3YI011PG3yLj7JdpQptaI8MKUySwPEQo1Q5MlHDmtJjm2/ auUyAsocxuczeUe7lKQ051c33ACGzaJWGHLCvrzeMR0DlGMtagW2Yg0nYs8JNGGf rq8nR/9ejwhK2WMZllELOZ+ym3sqpcW2watq2Zmv/dEtsjEgT8/gRO1GqlcWNZNa DDhRnFGcvy0Jf4q3NmRxGLON3xdoUTPQnaUlRY36VcFn5bCGxkAZjun9ObkMaKgT tfqySjg5cdWFaULmJBVu =diZ8 -----END PGP SIGNATURE----- --tr7rxvx6c4gh5lyu--