From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753394AbdBMPdQ (ORCPT <rfc822;w@1wt.eu>);
        Mon, 13 Feb 2017 10:33:16 -0500
Received: from mail.kernel.org ([198.145.29.136]:58514 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750943AbdBMPdN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 13 Feb 2017 10:33:13 -0500
Date: Mon, 13 Feb 2017 10:33:03 -0500
From: Steven Rostedt <rostedt@goodmis.org>
To: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>, Juri Lelli <juri.lelli@arm.com>,
        Tommaso Cucinotta <tommaso.cucinotta@sssup.it>,
        Luca Abeni <luca.abeni@santannapisa.it>
Subject: Re: [PATCH 2/2] sched/deadline: Throttle a constrained deadline
 task activated after the deadline
Message-ID: <20170213103303.0e3b3953@gandalf.local.home>
In-Reply-To: <a11b216b344a7ccdf7e3c89a6c8617bb446b91f7.1486754348.git.bristot@redhat.com>
References: <cover.1486754348.git.bristot@redhat.com>
        <a11b216b344a7ccdf7e3c89a6c8617bb446b91f7.1486754348.git.bristot@redhat.com>
X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, 10 Feb 2017 20:48:11 +0100
Daniel Bristot de Oliveira <bristot@redhat.com> wrote:

>  
> +static inline bool dl_is_constrained(struct sched_dl_entity *dl_se)
> +{
> +	return dl_se->dl_runtime < dl_se->dl_period;
> +}
> +

Is it ever appropriate for a dl task to have runtime == period? What
purpose would that serve? Just run the task as FIFO higher than
everything else.

Or was this suppose to be dl_deadline < dl_period?

-- Steve