From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752737AbdBMMG5 (ORCPT ); Mon, 13 Feb 2017 07:06:57 -0500 Received: from merlin.infradead.org ([205.233.59.134]:60320 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751966AbdBMMG4 (ORCPT ); Mon, 13 Feb 2017 07:06:56 -0500 Date: Mon, 13 Feb 2017 13:06:50 +0100 From: Peter Zijlstra To: Kefeng Wang Cc: Ingo Molnar , linux-kernel@vger.kernel.org, guohanjun@huawei.com, Prarit Bhargava Subject: Re: [PATCH] sched/isolcpus: Show isolated cpu map Message-ID: <20170213120650.GN6515@twins.programming.kicks-ass.net> References: <1486979039-17874-1-git-send-email-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1486979039-17874-1-git-send-email-wangkefeng.wang@huawei.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 13, 2017 at 05:43:59PM +0800, Kefeng Wang wrote: > The commit a6e4491c682a ("sched/isolcpus: Output warning when the > 'isolcpus=' kernel parameter is invalid") adds an error message > when specified cpu bigger than nr_cpu_ids, but nr_cpumask_bits in > cpulist_parse() could be nr_cpu_ids or NR_CPUS. > > eg, NR_CPUS=64, nr_cpu_ids=8 in ARM64, cpulist_parse() won't return > -ERANGE if isolcpus=1-10; > But why does cpulist_parse() use nr_cpumask_bits, that seems to be the problem, so why not look there?