From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753125AbdBMRr6 (ORCPT ); Mon, 13 Feb 2017 12:47:58 -0500 Received: from mx2.suse.de ([195.135.220.15]:57889 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751658AbdBMRr5 (ORCPT ); Mon, 13 Feb 2017 12:47:57 -0500 Date: Mon, 13 Feb 2017 18:47:40 +0100 From: Borislav Petkov To: "Kirill A. Shutemov" Cc: =?utf-8?B?SsOpcsOpbXk=?= Lefaure , x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] x86/vm86: fix unused variable warning if THP is disabled. Message-ID: <20170213174740.afcwcy6qvpi2euld@pd.tnic> References: <20170213100352.p2cgpbehza2hloji@pd.tnic> <20170213125228.63645-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20170213125228.63645-1-kirill.shutemov@linux.intel.com> User-Agent: NeoMutt/20161014 (1.7.1) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 13, 2017 at 03:52:28PM +0300, Kirill A. Shutemov wrote: > GCC complaines on unused variable 'vma' in mark_screen_rdonly() if THP > is disalbed: > > arch/x86/kernel/vm86_32.c: In function ‘mark_screen_rdonly’: > arch/x86/kernel/vm86_32.c:180:26: warning: unused variable ‘vma’ > [-Wunused-variable] > struct vm_area_struct *vma = find_vma(mm, 0xA0000); > ^~~ > It shoudln't really. The whole block has to be eliminated as > pmd_trans_huge() is 0 if THP is disabled. > > Anyway, this trick seems make GCC happy. Please run this commit message through a spellchecker - I see at least three typos. > Signed-off-by: Kirill A. Shutemov > Reported-by: Jérémy Lefaure Tested-by: Borislav Petkov -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg) --