From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753078AbdBMU0z (ORCPT ); Mon, 13 Feb 2017 15:26:55 -0500 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40432 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751731AbdBMU0y (ORCPT ); Mon, 13 Feb 2017 15:26:54 -0500 X-ME-Sender: X-Sasl-enc: SL6P8g68TGnRbf2nq7S45cxz9DmmndWzmzSLlRk0P81X 1487017612 Date: Tue, 14 Feb 2017 07:26:49 +1100 From: Tobin Harding To: Thomas Gleixner Cc: linux-kernel@vger.kernel.org, Ingo Molnar , "H. Peter Anvin" , x86@kernel.org Subject: Re: [PATCH 2/2] arch/x86: Fix sparse warning symbol not declared Message-ID: <20170213202649.GA24878@eros> References: <1486881870-2490-1-git-send-email-me@tobin.cc> <1486881870-2490-3-git-send-email-me@tobin.cc> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Mailer: Mutt 1.5.24 (2015-08-30) User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Feb 12, 2017 at 12:06:47PM +0100, Thomas Gleixner wrote: > On Sun, 12 Feb 2017, Tobin C. Harding wrote: > > > This patch adds function declaration in order to quiet sparse symbol > > not declared warning. > > Same comment vs. 'This patch' as before. Hint, we already know that this is > a patch, otherwise it would be mislabeled. > > > > > Signed-off-by: Tobin C. Harding > > --- > > > > Unsure why adding declaration quiets sparse. > > Because sparse finds a declaration before the definition. > > > This may not be the correct solution. > > Right, it's not. > > > Only testing done is building and booting kernel. Since 'purgatory' is > > called from assembler and does not need forward declaration the only > > advantage to this patch seems to be to save the next newbie from > > investigating the sparse warning. > > Well, yes. But just quietening a checker by slapping a pointless forward > declaration into the code is not pretty either. A smarter checker might > catch that. > > The proper solution is to have a local include file 'purgatory.h' and put > the declaration there. Include it in both files even if that's not required > for the ASM file. But that documents, that the function is used outside of > purgatory.c Blindly following instructions led to the bone headed patch I submitted yesterday (without building). Is there some way to include a C header in an ASM file that I do not know about? Thanks for patiently pointing out how to write a commit log. May I please bother you with another small etiquette question. Should I have replayed to you as I have done so or should I have re-sent another patch (v3) with the mistakes fixed (and stated in the log that I did not know how to implement the suggestions). thanks, Tobin.