From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753165AbdBMWAK (ORCPT ); Mon, 13 Feb 2017 17:00:10 -0500 Received: from mx1.redhat.com ([209.132.183.28]:54198 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752047AbdBMWAI (ORCPT ); Mon, 13 Feb 2017 17:00:08 -0500 Date: Mon, 13 Feb 2017 16:00:02 -0600 From: Josh Poimboeuf To: Marc MERLIN Cc: linux-kernel@vger.kernel.org Subject: Re: Please turn "Cannot use CONFIG_STACK_VALIDATION" into build error Message-ID: <20170213220002.2hqnarjvx3ev2nl3@treble> References: <20170213080709.o5oxyu646ajawzwp@merlins.org> <20170213184106.kkn7dnfszm7u72ek@treble> <20170213213132.GA28220@merlins.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170213213132.GA28220@merlins.org> User-Agent: Mutt/1.6.0.1 (2016-04-01) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 13 Feb 2017 22:00:09 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 13, 2017 at 01:31:32PM -0800, Marc MERLIN wrote: > Anyway, after not finding it in xconfig, I editted .config, and did: > # CONFIG_STACK_VALIDATION is not set > save .config > and the next build re-enabled the option. > That's what caught me by surprise. Did I do something wrong, or is there an > issue there? I really don't see how it would be possible for it to come back by itself, as it's disabled by default, and no other options select it. When I remove it, it stays disabled. > > Ideally the same warning should be printed when building OOT modules. > > I'll try to figure out if there's a way to do that it. > > This would help, although in that case you can even make the warning an > error since objtool missing seems to be fatal? It doesn't need to be fatal though. It should just be a warning and the build should succeed, like it does when building the kernel. -- Josh