From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751647AbdBNFLZ (ORCPT ); Tue, 14 Feb 2017 00:11:25 -0500 Received: from gateway20.websitewelcome.com ([192.185.54.2]:22818 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750859AbdBNFLX (ORCPT ); Tue, 14 Feb 2017 00:11:23 -0500 Date: Mon, 13 Feb 2017 22:50:51 -0600 Message-ID: <20170213225051.Horde.FuA7hX2Mg68zi7e218F_3so@gator4166.hostgator.com> From: "Gustavo A. R. Silva" To: Michal Nazarewicz Cc: Andy Shevchenko , gregkh@linuxfoundation.org, balbi@kernel.org, heikki.krogerus@linux.intel.com, mail@iagoabal.eu, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Senna Tschudin Subject: Re: [PATCH v2] usb: gadget: udc: remove pointer dereference after free References: <20170208191549.GA3998@embeddedgus> <1486582639.2133.412.camel@linux.intel.com> <20170208153322.Horde.mdD6qAMhN7aTL6u10JtoBcQ@gator4166.hostgator.com> <20170211110731.Horde.BPRpngvnMPXYcqid3jyhoJ-@gator4166.hostgator.com> In-Reply-To: User-Agent: Horde Application Framework 5 Content-Type: text/plain; charset=utf-8; format=flowed; DelSp=Yes MIME-Version: 1.0 Content-Disposition: inline Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 108.167.133.22 X-Exim-ID: 1cdV4m-000TdZ-HS X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: gator4166.hostgator.com [108.167.133.22]:16602 X-Source-Auth: garsilva@embeddedor.com X-Email-Count: 2 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Michal, Quoting Michal Nazarewicz : > On Sat, Feb 11 2017, Gustavo A. R. Silva wrote: >> Remove pointer dereference after free and set pointer to NULL after free. >> >> Addresses-Coverity-ID: 1091173 >> Signed-off-by: Gustavo A. R. Silva > > Acked-by: Michal Nazarewicz > >> --- >> Changes in v2: >> Move pointer dereference before pci_pool_free() >> Set pointer to NULL after free >> >> drivers/usb/gadget/udc/pch_udc.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/usb/gadget/udc/pch_udc.c >> b/drivers/usb/gadget/udc/pch_udc.c >> index a97da64..73bb58f 100644 >> --- a/drivers/usb/gadget/udc/pch_udc.c >> +++ b/drivers/usb/gadget/udc/pch_udc.c >> @@ -1522,8 +1522,9 @@ static void pch_udc_free_dma_chain(struct >> pch_udc_dev *dev, >> /* do not free first desc., will be done by free for request */ >> td = phys_to_virt(addr); >> addr2 = (dma_addr_t)td->next; >> - pci_pool_free(dev->data_requests, td, addr); >> td->next = 0x00; > > Or just drop this. pci_pool_free doesn’t care about contents of td. > It’s just a void* for it. > >> + pci_pool_free(dev->data_requests, td, addr); >> + td = NULL; > > This isn’t necessary either. td will get overwritten on next iteration > and once we’re done it’s not used again. > >> addr = addr2; >> } >> req->chain_len = 1; > Thanks for your comments, I will send version 3 shortly. -- Gustavo A. R. Silva