From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751505AbdBMXBU (ORCPT ); Mon, 13 Feb 2017 18:01:20 -0500 Received: from LGEAMRELO12.lge.com ([156.147.23.52]:58366 "EHLO lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751289AbdBMXBS (ORCPT ); Mon, 13 Feb 2017 18:01:18 -0500 X-Original-SENDERIP: 156.147.1.121 X-Original-MAILFROM: byungchul.park@lge.com X-Original-SENDERIP: 10.177.222.33 X-Original-MAILFROM: byungchul.park@lge.com Date: Tue, 14 Feb 2017 08:00:55 +0900 From: Byungchul Park To: Oleg Nesterov Cc: Peter Zijlstra , mingo@kernel.org, neilb@suse.de, nab@linux-iscsi.org, viro@zeniv.linux.org.uk, ying.huang@intel.com, shli@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 8/9] sched: Don't reinvent the wheel but use existing llist API Message-ID: <20170213230055.GN16086@X58A-UD3R> References: <1486970469-30917-1-git-send-email-byungchul.park@lge.com> <1486970469-30917-9-git-send-email-byungchul.park@lge.com> <20170213100457.GL6515@twins.programming.kicks-ass.net> <20170213155229.GA1663@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170213155229.GA1663@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 13, 2017 at 04:52:30PM +0100, Oleg Nesterov wrote: > On 02/13, Peter Zijlstra wrote: > > > > On Mon, Feb 13, 2017 at 04:21:08PM +0900, Byungchul Park wrote: > > > + llist_for_each_entry(p, llist, wake_entry) > > > + ttwu_do_activate(rq, p, p->sched_remote_wakeup ? WF_MIGRATED : 0, &rf); > > > > I think this suffers the exact same problem the others did. After > > ttwu_do_activate() the llist entry can be reused, so doing list_next() > > after it is flaky. > > llist_for_each_entry_safe() should work, I guess. Yes. I will fix it. Thank you. > > Oleg.