From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753083AbdBNWQF (ORCPT ); Tue, 14 Feb 2017 17:16:05 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:56766 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751642AbdBNWQC (ORCPT ); Tue, 14 Feb 2017 17:16:02 -0500 Date: Tue, 14 Feb 2017 14:15:51 -0800 From: Andrew Morton To: Sudip Mukherjee Cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH] m32r: mm: fix build warning Message-Id: <20170214141551.93d31680b42e255b7c604e51@linux-foundation.org> In-Reply-To: <1487109945-5342-1-git-send-email-sudipm.mukherjee@gmail.com> References: <1487109945-5342-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Feb 2017 22:05:45 +0000 Sudip Mukherjee wrote: > The build of m32r was giving warning: > mm/pgtable-generic.c: In function 'ptep_clear_flush': > mm/pgtable-generic.c:76:20: warning: > unused variable 'mm' [-Wunused-variable] > > The implementation of ptep_get_and_clear() and pte_accessible() > does not use 'mm'. That's because ptep_get_and_clear() and pte_accessible() are implemented as macros. If they were (static inline) C functions then this warning wouldn't occur. All the other architectures get this right.