From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754284AbdBNPUu (ORCPT ); Tue, 14 Feb 2017 10:20:50 -0500 Received: from mail-wr0-f194.google.com ([209.85.128.194]:34765 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754259AbdBNPUi (ORCPT ); Tue, 14 Feb 2017 10:20:38 -0500 Date: Tue, 14 Feb 2017 16:20:34 +0100 From: Jiri Pirko To: Colin Ian King Cc: Jiri Pirko , Jamal Hadi Salim , "David S. Miller" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: sched: check negative err value to safe one level of indent Message-ID: <20170214152034.GB7671@nanopsycho> References: <295e658c-d36b-94da-2efe-fb3cf72cc176@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <295e658c-d36b-94da-2efe-fb3cf72cc176@canonical.com> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Tue, Feb 14, 2017 at 04:10:13PM CET, colin.king@canonical.com wrote: >Jiro, > >A recent static analysis run with CoverityScan identified a potential >change in functionality with your recent commit "sched: check negative >err value to safe one level of indent" that landed in linux-next. > >The original path for case RTM_DELTFILTER would always goto errout, but >your commit seems to goto errout only if err is non-zero zero and the >err == 0 path falls through to the RTM_GETTFILTER case. I'm not sure if >this is an intentional change in behaviour. From what I can make out, >there is a missing goto errout before the fall-through to RTM_GETTFILTER. Will fix. Thanks. > >Colin