From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754576AbdBNP6A (ORCPT ); Tue, 14 Feb 2017 10:58:00 -0500 Received: from mail-db5eur01on0085.outbound.protection.outlook.com ([104.47.2.85]:44348 "EHLO EUR01-DB5-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753996AbdBNP5u (ORCPT ); Tue, 14 Feb 2017 10:57:50 -0500 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Mark.Rutland@arm.com; Date: Tue, 14 Feb 2017 15:57:43 +0000 From: Mark Rutland To: Chunyan Zhang CC: , , , , , , , , , Subject: Re: [PATCH 1/5] arm64: dts: Add basic DT to support Spreadtrum's SP9860G Message-ID: <20170214155743.GG23718@leverpostej> References: <1487063952-7113-1-git-send-email-chunyan.zhang@spreadtrum.com> <1487063952-7113-2-git-send-email-chunyan.zhang@spreadtrum.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1487063952-7113-2-git-send-email-chunyan.zhang@spreadtrum.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Originating-IP: [217.140.96.140] X-ClientProxiedBy: DB6PR0601CA0032.eurprd06.prod.outlook.com (10.169.209.18) To DB6PR0802MB2391.eurprd08.prod.outlook.com (10.172.250.144) X-MS-Office365-Filtering-Correlation-Id: a7fbc7a3-51f8-4ae5-a81c-08d454f23827 X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(48565401081);SRVR:DB6PR0802MB2391; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2391;3:+jTaT3IQBR2kq3VTEnvajMvgEuk6Tk9EoTjkGGHtIvppXPwO0ADijLBPDz/yWnaFnneerMwGPpuvWil9ATSocf+IZmsUxqbye/Lx86s/XLoYA269suxUbXQfJaQJnke4EzDja18GsUu/JOhsZaYA/QCp0JKc4Z4kplbw1KWBXDsCk/TMpper/060vrAGhG6+euDNjkzKyrqKOycpr6Baoj2F16HxsK+HMLbNlIDECDVftEzVXtDsa7TVqIIH0YPSF87WGoawWNcvMpuTfrvQzRj/vX0xAhJIw/jM9m49fUs=;25:V0FkwiEcVPWoSNkHWUz6xO/+wvzHKYxF3PZHPLwy1SiH/yJ6fJhppcmBDeFhv61r1F1wOrSTCV886w9X9VP1Schbhso4MxMkNjW61s/6Xp6XCuM68Irys7si8LAdU6BJeFsKpnvuDyS+IryrITXofH74fZQu5CKk2Zwx9X7LFLqY/aSjCumwN12a7Zfvxy+iDzo9jjaPIIIO5THT0pd+YvwddAkWIb/LSEfAbnXM9AOjbXh6V/lJcz6RNvaQkRfLVvTPip8zP4WxKcf7OqIY2ol+UOl07rBGEjYDuZEJWUU/5P9rGFvx/Aw5ZVze0FcVPUu1FHpFUl9GBj8wgTi/TTGDh8VxGJEYb2fKl+GvDRK84TQcCZ5bbSEFYB0kvgO0PLHQtryqeJXLjkfNRTkiC3ES11X9PF++MCRnChJsaNiOoAiKcdN+1zwX+dOougyd1NQMK4f2pYZGtgLbEKC2uw== X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2391;31:bGtJv1rKHYd8T5fgaOSC3+PSeM4C88hXmgZAJHqvPVNANqPkx5Fwk3NwlDRIw2LyJ92MLYm2Ar5NmyL1o5j4tUY5xH9yGRwEb2MhemWdD4rxh0FpyIIAUFhSFdS2NrKiHKj4kmpwuYdUvC7T2FujeHbDk+pZbFavfFUjJm0z7gXg5zcoijC84fr02i0p0HmBvYj8kfVp0iJozeQ/WS60aqS6rDCZkDGbDf/7MgrQ8uB7JPPn/9OksBJrr7IHrTKE;20:KEz63rS9EQmdiqP1CydPz9UIe51OlsRn9ri4MpiblaaIuifuNgpiiggSOfXbKHBWwXH8fbrjdTmaqzqvJ8doxFxC3CxJEA9NHW9IKELK6v/J7hHNCY/j7yxxdvGONHxTL2xHUEj9+4FluUq5JDO3s0s0ZWEyngHfZ4MXn+xuH/Y= NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040375)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6041248)(20161123562025)(20161123560025)(20161123558025)(20161123555025)(20161123564025)(6072148);SRVR:DB6PR0802MB2391;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0802MB2391; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2391;4:DUfFTYFlOsu9QA0qicVcMmqQr/FJtqsfgYWf+ykkB909pgKqsK/OXIdxD86NqCnsc62SrnRhxd9f9oSQA9LohfKY7O/iv+OUPlqkRTgAi+VVcVo7SXyXsnGSLkCx40+Sa+1KpMC4xuR0V1Nuk/8NR+Q9lOOV+ZkiEVBviWD0c6a+1z6lrhEWm/DUdgs6KQ5sNRlJS+Qyx6KW6pcBb7fMyI977JmMbQI2RSs//IZ6CLYyKAS7EineeIoBpvrNBhPNVyrNmmVKN7cRuOxLyFZCpL28HeAhHXKFmYbmxt9LWwrf1cOCxW3r9gX/94zV9f9WXlXuDw3twCoaJJTtv29yMoTXrTsrl/lqDGY4s0KV8MlSSJ9j9xJYfWckEC35BDIRV24Lmy9Q5KcqJ06We+1+CfFANOw/q94reZnQ+Mhv0ypde9rAUNmE9Hlyul75Snv/aJmakwhFT1M2RNxPCJYhx61/+xJcSDnjf8K4gtH6686nTWvP5Ot5oc/3b8EBi8GXw7c/N2Tvr09V2j1DLkgEl/QcdyeKFUC5zd2Oo55saLQBStXy8MucXLdH8HeWZ5bKxTOjR7ST13Olddj+6fEGTdp4qQAzGtTXUHakaLSmlRq1LnWgrx2RKf/Kf6e8I8/M X-Forefront-PRVS: 0218A015FA X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(39860400002)(39840400002)(39850400002)(39410400002)(39450400003)(199003)(189002)(24454002)(47776003)(97736004)(8676002)(4001350100001)(55016002)(81166006)(81156014)(50986999)(6496005)(229853002)(6116002)(1076002)(97756001)(6666003)(76176999)(54356999)(86362001)(6916009)(3846002)(54906002)(110136004)(38730400002)(53936002)(7736002)(83506001)(33656002)(5660300001)(189998001)(68736007)(92566002)(9686003)(106356001)(46406003)(305945005)(25786008)(2906002)(2950100002)(23726003)(105586002)(66066001)(50466002)(42186005)(101416001)(33716001)(4326007)(6246003)(81003)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0802MB2391;H:leverpostej;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0802MB2391;23:u40ygQauUY3DL/1u/egmtovBIN+AAgxoYuQLM6E?= =?us-ascii?Q?m3lrlh1+gSB8eeslWEqzc5Ec9C7qukYuNpAMeBhMh3jQ0OIfNzM8YcdXfiMx?= =?us-ascii?Q?1cuWYBVst1NtpyXT02bLnQ/lW5mxItdmJ0Mv71FrYlLbWU2zJMQQcbmReFHb?= =?us-ascii?Q?PJchvmpBfZBomiXvr6BMjY3cKsKKaN2tL/Th2CAIrCyQ9W9ik29k0bbqwGfq?= =?us-ascii?Q?+OwhWOl2ta/c2FazCOUSzymQgT4uq3WwAlQKYTyt4zXCcTFj0yAfx5jd0+rk?= =?us-ascii?Q?w7qxKDx60KUHtLs50Wx7osqVnVxap9/O5EbsD86F5IiTzO/oxRnJdEb7HlqS?= =?us-ascii?Q?JdseEBuBYv8FfqlMX0VvmoWnCsXyztB06UP4G4nI9IPC41YsD9Ph7wZjhEEm?= =?us-ascii?Q?GHz4ZFDxitzDHy8DvYkhLGAG9r4ioN1ilOWZoqyZBr8NwksrpI0EFxt0/h/k?= =?us-ascii?Q?OfT2sZzA2OUgXSisweNF7PdLSZ1genhJOQEvThphFkgGM9XubFIqaNsj5Ue2?= =?us-ascii?Q?K5jywXoDRllmjTpHMR7JwGQEPZvTEI2aEsYlWHs4lnY2OhteTgsp1ZR3AG9E?= =?us-ascii?Q?8FMznfcoIVw2XjjrxjDCBD5N1D9835vD4utWvqAAaeN6QwRKxBpgqk8X2nCb?= =?us-ascii?Q?c4B2mP5U17B8Ti9inZQGBgSjrJLD7n4WoMLqqLjYzd6tjfmZi5XQebB70oyn?= =?us-ascii?Q?WeqW3ZkWL1I9zR77Kx3K1sFnq1J61sD+B8zBdcWRDqRtfT68YbJX8yc+A0Hl?= =?us-ascii?Q?WtZQz7e7+ZLjiA3N10oW2vhtkWJZnNV9TDN17k0bwLrxICqU9ghDF++P8ddC?= =?us-ascii?Q?LpkKI/II/8N9BiTr42zMjz+KAYwkmrDU3O+7EjcTbu8nFnqnXQSpxxH+Pdb4?= =?us-ascii?Q?Y38YRrALcrccfUFFIaqZ/f2WeVFvCsPcT3FgcOHpYk5ZTI8cFTwPTjikei4V?= =?us-ascii?Q?pNqAHeNFdJg/2VDvaHFWXO4NFsbaR4WRCSoWg4YOfa64qT7XC+us5Jg37b7i?= =?us-ascii?Q?U7Y9LV6Us2I/snTUmzPQn2QPWyjYgd0CQUpl32lESDBEHh/Y7TvINlZDIKW8?= =?us-ascii?Q?1jZL3nNz/bVn6q9vyT5RiScEp6NzAn4MD6k1ZzOpbzEUF0U7VuG69eeLnApt?= =?us-ascii?Q?0H0hU1NLLtIvLESGVO86mppJQu74AWq6Vz+q0fyFnC2Mgo2sAe6B79aWpyCF?= =?us-ascii?Q?WGxBlNZb/uzTv9Nn2dFpAeY25L8LTZQurxSLJlKI20EN0axvrxKLgxK9lfcq?= =?us-ascii?Q?Pq75NQN3v3OKU4mFG6+QTayFzFwV1YkmXVL2EnRFR0lSqaq08JfeYY7NS/Ds?= =?us-ascii?Q?/nKq6H3Bpb4WYdevoMAa3II+hQhCI51pCn6Ncc/a7ZoCRmsTS13LFxn1wFKV?= =?us-ascii?Q?0Zz5C0VYbaJzKIWuIcpYYxCBVn/JCVP37FCgx0JF5/NzCveGTelKNR7XcLj0?= =?us-ascii?Q?YEbdsz9d6EA=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2391;6:lpIWrH2en/QF+RHoF93fkMjsvJ9FX+G/l4R4FEoEsjtUMhbH40p0B8E/DHePesMCXT6f/ylhysgeuK0XvyKJQV9Tfq2k8R4E8rQXrtAuoCjlLM87XFrl6kwU06Yv/GYj2RZQU3Of7vm7DtHRUAS8fIiG5PclmYOOD7Y/13N5IV/6QNXLZvDj5w3fSM4iFP4PLQ2PEDoZEcAoY4VCcIQaMFnT10/WSICPUQRBz3XZxiVLod/9EKSyJETtbg1YQ5oBMJfuIov2Ab8AK1+fml0rm2osh68VTCQJWb8RsypkGnN6fHkyeYOnNRUsUrIsoS3MDgxVP7YassWdVRwQbqRyHQUePhWJXmK5XLEMZ/5GFjva8K9O58y0xRuSOG5y53x1QxP4vqzkogsw85fiCOZf0u6kqqTAkt44DP8HWewTXto=;5:e9PnyCk6T65Bd+fsUrozGjc+QmNt7Io/qa5tQIpozB6DGIq+XFQKMKrHdC6k8bZOSrkXu47wO3xSJNBXHVHPYpeSqswTqALlx6G0Co4ispNFNgjf63kRS0xrhvA2tC64UdZfWFRunvwucfhbCyHiMQ==;24:yWufzOpnDiwNKiwnE/DRUgokS1HwYr2azslpVjAoiHaF14ME7S2LlVfAp1iau85NdLP1g3Bo33PvWN9ilSLH5g+JmwRNJ4WIJAh68LXAPUs= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0802MB2391;7:rt9aUEZaa+xX4X5PuFqZiQN1HUfl9ZRmGQBzSdIkAlmLXFFp0GpveKaB9AqLCMVO5hYekiOepuCROnEMML2CKtBoSxGnclDQAee6xbEq+sX1dQUFTRP5tGpvWDWnft6GCwQvCZM34t/Bvi0aBoFt4GiAVDTub5HHwKdTEeevBSgHdtrXTeIZ6A7kqeRGsCQ59lJFOaDygt9DJaRal3hqCqrpcH+C7uPwQHr8Wers0UwkxqVpY7pvrAJ4Gq+/oSJHYy9/3SwIl9uAMgHcMcXtfPzAtexhZRq/vxSVwRiJCCgdrXXrThc+qaia3NcZvPb60Wzvjk78bbODlcCDEHjiVZSbA/xPP0sR9EuvMI1asiTxXrWke3iMV1BqUSV/tL6t5udVt2AZHM9xg/S7yDNEh/EYdTQvTSJfiz4Pt6NqCw1CyFkS1zUEJ3BoIrVYgFn5DAuAHAgAeW3tXnnU8YctY+RnsweS5PTCzWsWId+F5VIl3MkAmqznnHVEed+KVqqhb2RJKyQ+33LU5MXfXbjtrQ== X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2017 15:57:46.4562 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0802MB2391 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Tue, Feb 14, 2017 at 05:19:08PM +0800, Chunyan Zhang wrote: > + timer { > + compatible = "arm,armv8-timer"; > + interrupts = + | IRQ_TYPE_LEVEL_LOW)>, > + + | IRQ_TYPE_LEVEL_LOW)>, > + + | IRQ_TYPE_LEVEL_LOW)>, > + + | IRQ_TYPE_LEVEL_LOW)>; > + clock-frequency = <26000000>; > + }; Your FW should program CNTFRQ on all CPUs, and this clock-frequency property should not be necessary. Please remove it. > + > + pmu { > + compatible = "arm,armv8-pmuv3"; Please list "arm,cortex-a53-pmu" first. > + interrupts = , > + , > + , > + , > + , > + , > + , > + ; > + }; As you are using SPIs, please add an interrupt-affinity property, per Documentation/devicetree/bindings/arm/pmu.txt. > diff --git a/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > new file mode 100644 > index 0000000..59390fc > --- /dev/null > +++ b/arch/arm64/boot/dts/sprd/sp9860g-1h10.dts > @@ -0,0 +1,58 @@ > +/* > + * Spreadtrum SP9860g board DTS file > + * > + * Copyright (C) 2017, Spreadtrum Communications Inc. > + * > + * This file is licensed under a dual GPLv2 or X11 license. > + */ > + > +/dts-v1/; > + > +#include "sc9860.dtsi" > + > +/ { > + model = "Spreadtrum SP9860G 3GFHD Board"; > + > + compatible = "sprd,sc9860", "sprd,sp9860g-1h10"; > + > + sprd,sc-id = <9860 1 0x20000>; What is this? I can't see any documentation or user of this property in mainline. Thanks, Mark.