From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754735AbdBNQdZ (ORCPT ); Tue, 14 Feb 2017 11:33:25 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:35246 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754020AbdBNQdR (ORCPT ); Tue, 14 Feb 2017 11:33:17 -0500 Date: Tue, 14 Feb 2017 11:33:07 -0500 From: Johannes Weiner To: Vlastimil Babka Cc: linux-mm@kvack.org, Joonsoo Kim , David Rientjes , Mel Gorman , linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH v2 01/10] mm, compaction: reorder fields in struct compact_control Message-ID: <20170214163307.GB2450@cmpxchg.org> References: <20170210172343.30283-1-vbabka@suse.cz> <20170210172343.30283-2-vbabka@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170210172343.30283-2-vbabka@suse.cz> User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 10, 2017 at 06:23:34PM +0100, Vlastimil Babka wrote: > While currently there are (mostly by accident) no holes in struct > compact_control (on x86_64), but we are going to add more bool flags, so place > them all together to the end of the structure. While at it, just order all > fields from largest to smallest. > > Signed-off-by: Vlastimil Babka Acked-by: Johannes Weiner