From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754621AbdBNR5G (ORCPT ); Tue, 14 Feb 2017 12:57:06 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:43733 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752271AbdBNR46 (ORCPT ); Tue, 14 Feb 2017 12:56:58 -0500 Date: Tue, 14 Feb 2017 09:56:41 -0800 From: Ram Pai To: Julia Lawall Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, agk@redhat.com, snitzer@redhat.com, corbet@lwn.net, shli@kernel.org, hbabu@us.ibm.com Subject: Re: [PATCH v4 1/1] DM: inplace compressed DM target (fwd) Reply-To: Ram Pai References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17021417-0020-0000-0000-00000B5E6C2F X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006616; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000203; SDB=6.00821907; UDB=6.00402031; IPR=6.00599360; BA=6.00005137; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00014280; XFM=3.00000011; UTC=2017-02-14 17:56:48 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17021417-0021-0000-0000-00005A1A8338 Message-Id: <20170214175641.GA10603@ram.oc3035372033.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-02-14_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1702140171 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 07:09:04AM +0100, Julia Lawall wrote: > On line 1759, since ret is unsigned it will not be less than 0. Thanks fixed it. Infact noticed that dm_icomp_io_range_compress() had missed a case where it was supposed to return error; a negative number. Fixed that aswell. RP > > julia > > ---------- Forwarded message ---------- > Date: Tue, 14 Feb 2017 09:00:39 +0800 > From: kbuild test robot > To: kbuild@01.org > Cc: Julia Lawall > Subject: Re: [PATCH v4 1/1] DM: inplace compressed DM target > > CC: kbuild-all@01.org > In-Reply-To: <1487018545-5061-2-git-send-email-linuxram@us.ibm.com> > > Hi Ram, > > [auto build test WARNING on dm/for-next] > [also build test WARNING on v4.10-rc8 next-20170213] > [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] > > url: https://github.com/0day-ci/linux/commits/Ram-Pai/DM-inplace-compressed-DM-target/20170214-055727 > base: https://git.kernel.org/pub/scm/linux/kernel/git/device-mapper/linux-dm.git for-next > :::::: branch date: 3 hours ago > :::::: commit date: 3 hours ago > > >> drivers/md/dm-inplace-compress.c:1759:5-8: WARNING: Unsigned expression compared with zero: ret < 0 > > git remote add linux-review https://github.com/0day-ci/linux > git remote update linux-review > git checkout e7924efaaba5efdcd28f32efbb949ed1153c932c > vim +1759 drivers/md/dm-inplace-compress.c > > e7924efa Ram Pai 2017-02-13 1743 * @io : io range > e7924efa Ram Pai 2017-02-13 1744 * @sector_start : the sector on backing storage to which the > e7924efa Ram Pai 2017-02-13 1745 * compressed data needs to be written. > e7924efa Ram Pai 2017-02-13 1746 * @meta_start: the page index of the bits corresponding to > e7924efa Ram Pai 2017-02-13 1747 * @meta_end : start and end blocks. > e7924efa Ram Pai 2017-02-13 1748 */ > e7924efa Ram Pai 2017-02-13 1749 static int dm_icomp_compress_write(struct dm_icomp_io_range *io, > e7924efa Ram Pai 2017-02-13 1750 sector_t sector_start, u64 *meta_start, u64 *meta_end) > e7924efa Ram Pai 2017-02-13 1751 { > e7924efa Ram Pai 2017-02-13 1752 struct dm_icomp_req *req = io->req; > e7924efa Ram Pai 2017-02-13 1753 sector_t count = DMCP_BYTES_TO_SECTOR(io->decomp_len); > e7924efa Ram Pai 2017-02-13 1754 unsigned int comp_len, ret; > e7924efa Ram Pai 2017-02-13 1755 u64 page_index; > e7924efa Ram Pai 2017-02-13 1756 > e7924efa Ram Pai 2017-02-13 1757 /* comp_data must be able to accommadate a larger compress buffer */ > e7924efa Ram Pai 2017-02-13 1758 ret = dm_icomp_io_range_compress(req->info, io, &comp_len); > e7924efa Ram Pai 2017-02-13 @1759 if (ret < 0) { > e7924efa Ram Pai 2017-02-13 1760 req->result = -EIO; > e7924efa Ram Pai 2017-02-13 1761 return -EIO; > e7924efa Ram Pai 2017-02-13 1762 } > e7924efa Ram Pai 2017-02-13 1763 WARN_ON(comp_len > io->comp_len); > e7924efa Ram Pai 2017-02-13 1764 > e7924efa Ram Pai 2017-02-13 1765 dm_icomp_get_req(req); > e7924efa Ram Pai 2017-02-13 1766 > e7924efa Ram Pai 2017-02-13 1767 io->io_req.bi_op = REQ_OP_WRITE; > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation -- Ram Pai