From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Richard Cochran <richardcochran@gmail.com>
Cc: "David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 2/4] ptp: use kcalloc when allocating arrays
Date: Tue, 14 Feb 2017 10:23:32 -0800 [thread overview]
Message-ID: <20170214182334.23296-3-dmitry.torokhov@gmail.com> (raw)
In-Reply-To: <20170214182334.23296-1-dmitry.torokhov@gmail.com>
kcalloc is more semantically correct when allocating arrays of objects, and
overflow-safe.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/ptp/ptp_sysfs.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/ptp/ptp_sysfs.c b/drivers/ptp/ptp_sysfs.c
index 53d43954a974..27cd46ab5e32 100644
--- a/drivers/ptp/ptp_sysfs.c
+++ b/drivers/ptp/ptp_sysfs.c
@@ -269,13 +269,12 @@ static int ptp_populate_pins(struct ptp_clock *ptp)
struct ptp_clock_info *info = ptp->info;
int err = -ENOMEM, i, n_pins = info->n_pins;
- ptp->pin_dev_attr = kzalloc(n_pins * sizeof(*ptp->pin_dev_attr),
+ ptp->pin_dev_attr = kcalloc(n_pins, sizeof(*ptp->pin_dev_attr),
GFP_KERNEL);
if (!ptp->pin_dev_attr)
goto no_dev_attr;
- ptp->pin_attr = kzalloc((1 + n_pins) * sizeof(struct attribute *),
- GFP_KERNEL);
+ ptp->pin_attr = kcalloc(1 + n_pins, sizeof(*ptp->pin_attr), GFP_KERNEL);
if (!ptp->pin_attr)
goto no_pin_attr;
--
2.11.0.483.g087da7b7c-goog
next prev parent reply other threads:[~2017-02-14 18:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 18:23 [PATCH v2 0/4] PTP attribute handling cleanup Dmitry Torokhov
2017-02-14 18:23 ` [PATCH v2 1/4] ptp: do not explicitly set drvdata in ptp_clock_register() Dmitry Torokhov
2017-02-14 18:23 ` Dmitry Torokhov [this message]
2017-02-14 18:23 ` [PATCH v2 3/4] ptp: use is_visible method to hide unused attributes Dmitry Torokhov
2017-02-14 18:23 ` [PATCH v2 4/4] ptp: create "pins" together with the rest of attributes Dmitry Torokhov
2017-02-15 17:22 ` [PATCH v2 0/4] PTP attribute handling cleanup David Miller
2017-02-16 10:30 ` Richard Cochran
2017-02-16 20:19 ` Richard Cochran
2017-02-17 16:03 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170214182334.23296-3-dmitry.torokhov@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome