From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755561AbdBNVZY (ORCPT ); Tue, 14 Feb 2017 16:25:24 -0500 Received: from mout.kundenserver.de ([212.227.126.134]:55228 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751444AbdBNVZS (ORCPT ); Tue, 14 Feb 2017 16:25:18 -0500 From: Arnd Bergmann To: Thomas Gleixner , Jason Cooper , Marc Zyngier Cc: Arnd Bergmann , Thomas Petazzoni , linux-kernel@vger.kernel.org Subject: [PATCH] irqchip: mvebu-odmi: select GENERIC_MSI_IRQ_DOMAIN Date: Tue, 14 Feb 2017 22:24:36 +0100 Message-Id: <20170214212502.2752378-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:/gT9DfLeOReY0AQ192IsEou88wg2U72EyxwOG4VKKu/qr3bIJu0 3ya9gqPfg6iHJq8W0cOpZT7UxN6XyhUhqyjiRTP3g2UR24YqvLEv4RLNv7kJ/GiRXPehgxz k0nODlniXEFMO1trde9m0k3M2fZ/LT79QFQkbZqyG3927xcV/wD54fgZtFYHNQheXyHkzjs /0CP2L7SjGRxn0Ft/kTOw== X-UI-Out-Filterresults: notjunk:1;V01:K0:JpEEdoJQ+Uo=:/Ruy4tqTj+7to9pxIBNqu3 oYwBIV/O09aAd+UJzUc41pPMeMbdeESTHgsTp7n7aOTsOO8m9dOt9maPwLhJ6jZjGMkaowG0K NNPwYmF6okM1067RxsZ1f9wUV4Bq+pC4mSkxZGVJfvev/7GM76KXewuJl04wnId6xdpj2PDVj bp1brdfCcHGhrCXM9EMP7apYhiExVLuDooaOEf6l3plv7NAWSYwPbQ8kYwmrCywj1kk4YDGGX QDXRcKS6JFxkcxNa/QDcmyAPsk0v/kY3ja2q4y6iBU8nIU4h0Qon0OIS5QnBR82GQsijJpFxN jJ30XdV7d9jM5pgIzOpFmLcfutZlTBy5Lr0CzEDmFP8fH3doCoqB7Bf+u4h1HJOJCdqCJzZXy D/y7MyZ4nT4bVSIxKDv0xwAEeDOeCYikUvKwRQTaxLgz9c4Uoc5NRIyNON0Z1EMZGpGnzhXIU F8ayuoBxdwg1HKMpBtfkcUTb/xRCo5zI+S34Sh+Uw4xlm9TaPmYTadwJIH8OuzEdgNsh2LbAp uCd8zGFj27EJMEH0zleu8j2aPs5f5KLkV4nJbXlSB8isDgY1yZRfa3a/qb2zqBZVvp0yGvL53 Z7nlA5r2SIHQNWcm35OGD145fWtivxsf44n4gzuABo1qsmCYf+l8nV7sqi/VN0lWFkt6ESH9a +ZX5n91a+tP9AX/SNyQ+u7UHVMpQKtgUUG6yl6jUjcMSLvBNShKL80U5omfbCA/kftrk= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This driver uses the MSI domain but has no strict dependency on PCI_MSI, so we may run into a build failure when CONFIG_GENERIC_MSI_IRQ_DOMAIN is disabled: drivers/irqchip/irq-mvebu-odmi.c:152:15: error: variable 'odmi_msi_ops' has initializer but incomplete type static struct msi_domain_ops odmi_msi_ops = { ^~~~~~~~~~~~~~ drivers/irqchip/irq-mvebu-odmi.c:155:15: error: variable 'odmi_msi_domain_info' has initializer but incomplete type static struct msi_domain_info odmi_msi_domain_info = { ^~~~~~~~~~~~~~~ drivers/irqchip/irq-mvebu-odmi.c:156:3: error: 'struct msi_domain_info' has no member named 'flags' .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), ^~~~~ drivers/irqchip/irq-mvebu-odmi.c:156:12: error: 'MSI_FLAG_USE_DEF_DOM_OPS' undeclared here (not in a function) .flags = (MSI_FLAG_USE_DEF_DOM_OPS | MSI_FLAG_USE_DEF_CHIP_OPS), ^~~~~~~~~~~~~~~~~~~~~~~~ drivers/irqchip/irq-mvebu-odmi.c:156:39: error: 'MSI_FLAG_USE_DEF_CHIP_OPS' undeclared here (not in a function); did you mean 'MSI_FLAG_USE_DEF_DOM_OPS'? Selecting the option from this driver seems to solve this nicely, though I could not find any other instance of this in irqchip drivers. Signed-off-by: Arnd Bergmann --- drivers/irqchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index ae96731cd2fb..fbb299c32e17 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -262,6 +262,7 @@ config IRQ_MXS config MVEBU_ODMI bool + select GENERIC_MSI_IRQ_DOMAIN config MVEBU_PIC bool -- 2.9.0