From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755636AbdBNVdL (ORCPT ); Tue, 14 Feb 2017 16:33:11 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:61036 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751855AbdBNVdJ (ORCPT ); Tue, 14 Feb 2017 16:33:09 -0500 From: Arnd Bergmann To: Mark Yao , David Airlie Cc: Sean Paul , Guenter Roeck , Arnd Bergmann , Heiko Stuebner , Daniel Vetter , Yakir Yang , Philipp Zabel , Chris Zhong , Tobias Jakobi , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH] drm/rockchip: add extcon dependency for DP Date: Tue, 14 Feb 2017 22:31:51 +0100 Message-Id: <20170214213215.2888509-1-arnd@arndb.de> X-Mailer: git-send-email 2.9.0 X-Provags-ID: V03:K0:98OU8Ek/k/w2OXvMe6Wtei8vmP7NfNqOoBOHszSvW+ve6Odp0NV CMI56pSoohvShQr1CTBsE83uI7rZtEKhauCMv2peJ0LuBTnHxLHCDIZsA8E6PadYYLxdpMB 6bG8jQekv0ZwBvy1ScZa1lwunOptui0lPAtSx4j/zmMsHBeTfaVC1O07itbQoqnJ4aT9veL zAaT6U+gv2kLxMLYHNUEQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:nXeP+yRGcSQ=:tFJWjUwooUFQTN+WUexEYl Vedrl/yYE3t/h3mSScdtFZaFN3CHspx4wooJtQ9k7D3VO0IGj1z9McE0lWFqAokciYUdzvZjO jzeV2qor0G9rvP8lQ9myuv4+HkoGedS8gzgNQzrJKPUylRwUouETs0fAucxtZF6dva1XVDpCL 6JB5G0oVmlgbrXdK7lo9NZU+HKTFDntwZrbRl67k2yOJCZnBXWcrK/TntdC+8oO53xQFItaZ5 72F4VHSynse/ByjLz7Mc25sQxGaQFg/C2FNAO5tmchjEEeXgsWVbIfkTIbcLCozyswWrp0pRt hY3tTSPBgHQmXSRL/RB9NBR0it/PjdIoVM1CVCKMvUrJOmU9j0VMuCQ9Hmw+auZ7HnwzWXZps tZDf2TGyMaign9kG+YpjT2KYGU7k1lKP2hhty+fjJKGVSU7O8rKYfm1Ifw7EWtH8cEjxp7sNs Af0Snmx5dP5EZvZSQFr7vz6YJDznX7sgwPzl8nvSFjK8qd0njlsNg9BUjZ99rUYDUFH5uQkBr PPlOoY5lZUbET4/BPgijPZTtkqNhlRB18gjBKxvBiFNVWK0zerI8+nwWN/oLJKrWRhiB/4qXo Jap9eMxgSihW2irQOqLg3VmHHS8U+IMqe/kO/sOiWY1Obouf2k0QbpYWxkzyVpCM4Fa0Ddj+F mIb1iQCRu9ZTnnZT9XnGFqRS2Lct0Qw4akp1vVXiprdZueo1Di3yXqUSvJVzHI472+xA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The newly added DP driver links against the extcon core, which fails when extcon is a module and this driver is not: drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes': cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state' cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property' Let's make Kconfig enforce correct behavior with a dependency. Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399") Signed-off-by: Arnd Bergmann --- drivers/gpu/drm/rockchip/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig index ad31b3eb408f..0e4eb845cbb0 100644 --- a/drivers/gpu/drm/rockchip/Kconfig +++ b/drivers/gpu/drm/rockchip/Kconfig @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP config ROCKCHIP_CDN_DP tristate "Rockchip cdn DP" depends on DRM_ROCKCHIP + depends on EXTCON select SND_SOC_HDMI_CODEC if SND_SOC help This selects support for Rockchip SoC specific extensions -- 2.9.0