From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751630AbdBODAP (ORCPT ); Tue, 14 Feb 2017 22:00:15 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:36612 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751318AbdBODAO (ORCPT ); Tue, 14 Feb 2017 22:00:14 -0500 Date: Tue, 14 Feb 2017 19:00:13 -0800 From: Greg KH To: Weiwei Jia Cc: bsingharora@gmail.com, linux-kernel@vger.kernel.org Subject: Re: [RFC] blkio_delay_total is calculated mistakenly Message-ID: <20170215030013.GA22460@kroah.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.2 (2016-11-26) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 14, 2017 at 08:27:36PM -0500, Weiwei Jia wrote: > Hi, > > When I read Linux Kernel source codes about how "blkio_delay_total" > (delay waiting for synchronous block I/O to complete for one task) is > calculated in Linux/kernel/delayacct.c file [1], I find that > "blkio_delay_total" adds "task->delays->blkio_delay" to be the total > delay time for one task to wait for synchronous I/O dynamically but > "tsk->delays->blkio_delay" has already been calculated as the total > delay time that one task is waiting for synchronous I/O [2] > dynamically. I think "blkio_delay_total" should not add > "task->delays->blkio_delay" since "task->delays->blkio_delay" is > already the total delay time we want. > > Am I missing anything? Why are you sending this to me? You have read Documentation/SubmittingPatches, right? Please use scripts/get_maintainers.pl for who to send patches to. thanks, greg k-h