From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751478AbdBOOZO (ORCPT ); Wed, 15 Feb 2017 09:25:14 -0500 Received: from mail.kernel.org ([198.145.29.136]:58878 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751210AbdBOOZN (ORCPT ); Wed, 15 Feb 2017 09:25:13 -0500 Date: Wed, 15 Feb 2017 09:25:07 -0500 From: Steven Rostedt To: Juri Lelli Cc: Byungchul Park , peterz@infradead.org, mingo@kernel.org, linux-kernel@vger.kernel.org, juri.lelli@gmail.com, kernel-team@lge.com, Luca Abeni Subject: Re: [PATCH] sched/deadline: Remove unnecessary condition in push_dl_task() Message-ID: <20170215092507.106f7964@gandalf.local.home> In-Reply-To: <20170215104749.GB1368@e106622-lin> References: <1487135511-15817-1-git-send-email-byungchul.park@lge.com> <20170215104749.GB1368@e106622-lin> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 15 Feb 2017 10:47:49 +0000 Juri Lelli wrote: > [+Steve, Luca] > > Hi, > > On 15/02/17 14:11, Byungchul Park wrote: > > Once pick_next_pushable_dl_task(rq) return a task, it guarantees that > > the task's cpu is rq->cpu, so task_cpu(next_task) is always rq->cpu if > > task == next_task. Remove a redundant condition and make code simpler. > > > > Signed-off-by: Byungchul Park > > --- > > kernel/sched/deadline.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c > > index 27737f3..ad8d577 100644 > > --- a/kernel/sched/deadline.c > > +++ b/kernel/sched/deadline.c > > @@ -1483,7 +1483,7 @@ static int push_dl_task(struct rq *rq) > > * then possible that next_task has migrated. > > */ > > task = pick_next_pushable_dl_task(rq); > > - if (task_cpu(next_task) == rq->cpu && task == next_task) { > > + if (task == next_task) { > > Seems a sensible optimization to me. Actually, we are doing the same for > rt.c; Steve, Peter, do you think we should optimize that as well? > Are we doing the same for push_rt_task()? I don't see it, and I don't see it in tip/sched/core either. What I have is: if (task_cpu(next_task) == rq->cpu && task == next_task) { But that said, I believe this patch is correct, and we should change rt.c as well. task = pick_next_pushable_dl_task(rq); Which has: BUG_ON(rq->cpu != task_cpu(task)) when it returns a task other than NULL. Which means that task_cpu(task) must be rq->cpu. Then if task == next_task, then task_cpu(next_task) must be rq->cpu as well. Reviewed-by: Steven Rostedt (VMware) Mind fixing rt.c if it hasn't been fixed already. -- Steve